Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed breaking bug in ABAction buttons #1334

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

mrvisscher
Copy link
Collaborator

The get_QButton method of ABActions did not run correctly on button activation as the getter method was not called properly, but passed through instead. This broke the buttons in at least the calculation setup tab, but probably also in other places.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • [ x] Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Aug 7, 2024
@mrvisscher mrvisscher added this to the 2.10.1 milestone Aug 7, 2024
@mrvisscher mrvisscher requested a review from marc-vdm August 7, 2024 09:24
@coveralls
Copy link

Coverage Status

coverage: 54.361%. remained the same
when pulling 6458002 on mrvisscher:fix-cs-list
into 7b1217d on LCA-ActivityBrowser:main.

@mrvisscher mrvisscher added the prio:high Issues that are high priority label Aug 8, 2024
@marc-vdm marc-vdm merged commit 25c7baa into LCA-ActivityBrowser:main Aug 9, 2024
9 checks passed
@mrvisscher mrvisscher deleted the fix-cs-list branch November 22, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs prio:high Issues that are high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calculation Setup: 'Duplicate', 'Rename', and 'Delete', return Error
3 participants