Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable collapsible panels in activity details #1335

Merged

Conversation

mrvisscher
Copy link
Collaborator

It was possible for exchange tables in the activity details tab to collapse, meaning they would become totally hidden/invisible. Normally this could be fixed by the user reloading the tab in some way or another, but since the last update the state of the tables is saved, meaning they will stay hidden. This PR disables the collapsible table functionality, as it is covered by the check-box functionality anyways.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the change PRs related to minor changes to AB label Aug 7, 2024
@mrvisscher mrvisscher added this to the 2.10.1 milestone Aug 7, 2024
@mrvisscher mrvisscher requested a review from marc-vdm August 7, 2024 09:55
@coveralls
Copy link

Coverage Status

coverage: 54.364% (+0.003%) from 54.361%
when pulling f08b53b on mrvisscher:fix-dissapearing-panels
into 7b1217d on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm merged commit 086ee4b into LCA-ActivityBrowser:main Aug 9, 2024
9 checks passed
@mrvisscher mrvisscher deleted the fix-dissapearing-panels branch November 22, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change PRs related to minor changes to AB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

categories 'biosphere flows' and 'projects' do not show up anymore
3 participants