Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging changes #1336

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Logging changes #1336

merged 3 commits into from
Aug 9, 2024

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Aug 7, 2024 •
edited
Loading

In this PR we rollback some changes to better supported and understood ones

  • The LoggingProxy class is removed in favor of the more standardized getLogger("__name__") method.
  • Exceptionhook logging is now logged under exception_hook instead of trying to find the module using inspect

Related

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the change PRs related to minor changes to AB label Aug 7, 2024
@mrvisscher mrvisscher added this to the 2.10.1 milestone Aug 7, 2024
@mrvisscher mrvisscher requested a review from marc-vdm August 7, 2024 14:33
@coveralls
Copy link

coveralls commented Aug 7, 2024 •
edited
Loading

Coverage Status

coverage: 54.132% (-0.3%) from 54.397%
when pulling 1f6a3f8 on mrvisscher:its_the_final_logger
into 8e1d44c on LCA-ActivityBrowser:main.

marc-vdm
marc-vdm approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@marc-vdm marc-vdm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-merge main but then LGTM

marc-vdm added a commit to polca/ScenarioLink that referenced this pull request Aug 9, 2024
@marc-vdm
Fig logging for LCA-ActivityBrowser/activity-browser#1336
6380972
@mrvisscher mrvisscher merged commit f28bdbd into LCA-ActivityBrowser:main Aug 9, 2024
9 checks passed
@mrvisscher mrvisscher deleted the its_the_final_logger branch November 8, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-vdm marc-vdm marc-vdm approved these changes

Assignees
No one assigned
Labels
change PRs related to minor changes to AB
Projects
None yet
Milestone
2.10.1
Development

Successfully merging this pull request may close these issues.

logger exception hook fails
3 participants
@mrvisscher @coveralls @marc-vdm