Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning dialogue to ActivityDelete action #1339

Merged

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Aug 8, 2024

The ActivityDelete action now asks for a confirmation from the user.

Animation

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher requested a review from marc-vdm August 8, 2024 13:28
@mrvisscher mrvisscher added the feature Issues/PRs related to a new feature label Aug 8, 2024
@mrvisscher mrvisscher added this to the 2.10.1 milestone Aug 8, 2024
@coveralls
Copy link

coveralls commented Aug 8, 2024

Coverage Status

coverage: 54.364% (+0.04%) from 54.328%
when pulling 455930d on mrvisscher:activity-delete-confirm
into 54d6a9c on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm merged commit 0456796 into LCA-ActivityBrowser:main Aug 9, 2024
9 checks passed
@mrvisscher mrvisscher deleted the activity-delete-confirm branch November 22, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues/PRs related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add confirmation dialog for deleting activity
3 participants