Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken database delete signalling #1357

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fixed broken database delete signalling #1357

merged 1 commit into from
Sep 16, 2024

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Sep 16, 2024 •
edited
Loading

Broken database delete signalling causes databases not to be deleted from the SQL-database, only from the metadata.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added bug Issues/PRs related to bugs prio:high Issues that are high priority labels Sep 16, 2024
@mrvisscher mrvisscher added this to the 2.10.2 milestone Sep 16, 2024
@mrvisscher mrvisscher requested a review from marc-vdm September 16, 2024 13:34
@coveralls
Copy link

Coverage Status

coverage: 54.099% (-0.03%) from 54.132%
when pulling a3419a5 on mrvisscher:database-delete-fix
into 54c987d on LCA-ActivityBrowser:main.

marc-vdm
marc-vdm approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@marc-vdm marc-vdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-vdm marc-vdm merged commit a453160 into LCA-ActivityBrowser:main Sep 16, 2024
9 checks passed
@mrvisscher mrvisscher deleted the database-delete-fix branch November 22, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-vdm marc-vdm marc-vdm approved these changes

Assignees
No one assigned
Labels
bug Issues/PRs related to bugs prio:high Issues that are high priority
Projects
None yet
Milestone
2.10.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mrvisscher @coveralls @marc-vdm