Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrations fix #1360

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Migrations fix #1360

merged 3 commits into from
Sep 17, 2024

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Sep 17, 2024 •
edited
Loading

Fixes bug in default project install, which right now doesn't install the default migrations. Also adds an action for users to install the default migrations manually.

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation, please follow the numpy style guide.
  • Update tests.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Link this PR to related issues by using closing keywords.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added bug Issues/PRs related to bugs change PRs related to minor changes to AB labels Sep 17, 2024
@mrvisscher mrvisscher added this to the 2.10.2 milestone Sep 17, 2024
@mrvisscher mrvisscher requested a review from marc-vdm September 17, 2024 11:42
@coveralls
Copy link

Coverage Status

coverage: 54.225% (+0.1%) from 54.118%
when pulling d8715c2 on mrvisscher:migrations-fix
into da34ce9 on LCA-ActivityBrowser:main.

marc-vdm
marc-vdm approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@marc-vdm marc-vdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-vdm marc-vdm merged commit acd6aa1 into LCA-ActivityBrowser:main Sep 17, 2024
9 checks passed
@mrvisscher mrvisscher deleted the migrations-fix branch November 22, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc-vdm marc-vdm marc-vdm approved these changes

Assignees
No one assigned
Labels
bug Issues/PRs related to bugs change PRs related to minor changes to AB
Projects
None yet
Milestone
2.10.2
Development

Successfully merging this pull request may close these issues.

Failed excel import due to missing core migrations Stuck when importing ecoinvent 3.9
3 participants
@mrvisscher @coveralls @marc-vdm