Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Impact Category list view actions #1363

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Sep 18, 2024

This PR fixes an issue where context menu actions in the Impact Category List view failed because they were triggered with a generator instead of the expected list object.

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Sep 18, 2024
@mrvisscher mrvisscher added this to the 2.10.2 milestone Sep 18, 2024
@mrvisscher mrvisscher requested a review from marc-vdm September 18, 2024 09:19
@coveralls
Copy link

Coverage Status

coverage: 54.205%. remained the same
when pulling dabd005 on mrvisscher:method-table-fix
into 5b4b200 on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm merged commit 1cda4fe into LCA-ActivityBrowser:main Sep 18, 2024
9 checks passed
@mrvisscher mrvisscher deleted the method-table-fix branch November 22, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't delete created method
3 participants