Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter Scenario fixes #1420

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Dec 17, 2024

Parameter scenario files currently give unexpected results when the default column is not supplied. This happens because parameters are not sampled based on their group-name combination but rather on their order within the file. This PR fixes this issue.

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Dec 17, 2024
@mrvisscher mrvisscher added this to the 2.10.4 milestone Dec 17, 2024
@mrvisscher mrvisscher requested a review from marc-vdm December 17, 2024 13:13
@coveralls
Copy link

Coverage Status

coverage: 53.298% (+0.02%) from 53.279%
when pulling 7d44823 on mrvisscher:sdf-fixes
into a1681e6 on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm modified the milestones: 2.10.4, 2.11.0 Dec 17, 2024
@marc-vdm marc-vdm merged commit 075f34e into LCA-ActivityBrowser:main Dec 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants