-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix negative contributions grouping under Rest issue #765
Conversation
Would it be a good idea to add TODOs to places that need to be changed back if this gets changed on the BW side? |
@nabilahmed739 I think it is awesome that you have submitted the PR. Thanks! I have merged your PR against bw2-analyzer, I think this is a better way to fix the underlying problem. I will release a new version today or tomorrow. |
@cmutel Yes, the change in bw2-analyzer would be perfect! |
The complete fix for #739 is the combination of bw2-analyzer update to version 0.11.2 and completion of this PR |
@cmutel I see bw2analyzer was updated, can we finalize this PR on AB side? |
@nabilahmed739 @marc-vdm All |
Fixes the way bw2-analyzer treats negative contributions on the AB side: brightway-lca/brightway2-analyzer#18
Note: If the above issue is fixed in bw2-analyzer in accordance with the current fix then this change can be reverted after consideration if even the changes in normalize method in multilca class is not required any more.
fixes #739