Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kernels::grisubal): rewrite step 1 to enable parallelization #210

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Oct 28, 2024

there are two main changes to make it happen:

  • split the main iterator in two, to compute and preallocate intersection metadata vector, allowing edition of the vector with no pushes
  • rewrite the second part of the iterator to collect (K, V) pairs directly into the Hashmap rather than insert each manually

using the bench scripts, it seems like the performance is unchanged for now, which is a win since step 1 is now parallelizable

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.70%. Comparing base (d79671f) to head (549bd42).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   82.04%   82.70%   +0.66%     
==========================================
  Files          41       41              
  Lines        5681     5898     +217     
==========================================
+ Hits         4661     4878     +217     
  Misses       1020     1020              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99 imrn99 marked this pull request as ready for review October 28, 2024 12:01
@imrn99
Copy link
Collaborator Author

imrn99 commented Oct 29, 2024

I think I will split the kernel.rs file into a module in a separate PR. the file is starting to be very long, and each step are starting to contain many substeps

@imrn99 imrn99 merged commit b3e6c20 into master Oct 29, 2024
13 checks passed
@imrn99 imrn99 deleted the rewrite-grisubal-step1 branch October 29, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants