-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(kernels::grisubal): rewrite step 1 to enable parallelization #210
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 82.04% 82.70% +0.66%
==========================================
Files 41 41
Lines 5681 5898 +217
==========================================
+ Hits 4661 4878 +217
Misses 1020 1020 ☔ View full report in Codecov by Sentry. |
I think I will split the |
there are two main changes to make it happen:
(K, V)
pairs directly into the Hashmap rather than insert each manuallyusing the bench scripts, it seems like the performance is unchanged for now, which is a win since step 1 is now parallelizable