Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kernels::grisubal): improve dart preallocation code #211

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Oct 29, 2024

replace a quadratic loop with a proper scan at two occurences

@imrn99 imrn99 changed the title refactor(kernels): improve dart preallocation code refactor(kernels::grisubal): improve dart preallocation code Oct 29, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.62%. Comparing base (308afbb) to head (290094a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   82.60%   82.62%   +0.01%     
==========================================
  Files          41       41              
  Lines        5865     5870       +5     
==========================================
+ Hits         4845     4850       +5     
  Misses       1020     1020              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99 imrn99 merged commit e529756 into master Oct 29, 2024
13 checks passed
@imrn99 imrn99 deleted the improve-preallocs branch October 29, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants