refactor!: delete the i-cell collection structures #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 78.97% 78.93% -0.04%
==========================================
Files 52 51 -1
Lines 6834 6822 -12
==========================================
- Hits 5397 5385 -12
Misses 1437 1437 ☔ View full report in Codecov by Sentry. |
|
should the fetch methods be renamed to |
cedricchevalier19
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scope: core with side effects everywhere
Type of change: refactor
Content description:
Delete
VertexCollection,EdgeCollection,FaceCollection& replace thefetch_<ICELL>return type to a lifetime'd iterator.Additional information