Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust docs for ethers recoverPublicKey prefixing the public key with 0x #399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ranile
Copy link

@ranile ranile commented Jan 16, 2025

Description

Update "Signing Data" with PKP docs.ethers.utils.recoverAddress returns 0x${publicKey} (lit doesn't prefix with 0x in responses to mint/sign) so the assertion from docs (recoveredPubkey === pkpInfo.publicKey) fails.

Demo: https://stackblitz.com/edit/lit-pkp-signed-pubkey-mismatch-demo?file=src%2Fmain.ts

Type of change

Documentation update

Checklist:

General

  • I have performed a self-review of my code
  • I have fixed all grammar issues (can use an AI tool to check), and explanations are in active voice
  • I have checked the additions are concise
  • Language is consistent with existing documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published (ie. SDK changes, node dependencies)

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 4:30pm

Copy link

netlify bot commented Jan 16, 2025

Deploy Preview for lit-dev-docs ready!

Name Link
🔨 Latest commit 40bc340
🔍 Latest deploy log https://app.netlify.com/sites/lit-dev-docs/deploys/678933faaf77f30008425d57
😎 Deploy Preview https://deploy-preview-399--lit-dev-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant