Cyt 814 docker scout #193
Merged
Cyt 814 docker scout #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…o CYT-814-docker-scout
for more information, see https://pre-commit.ci
nightlark
reviewed
May 10, 2024
for more information, see https://pre-commit.ci
nightlark
reviewed
May 24, 2024
|
|
||
| def is_docker_scout_installed(): | ||
| # Check that Docker Scout can be run | ||
| result = subprocess.run(["docker", "scout", "--help"], capture_output=True, check=False) |
There was a problem hiding this comment.
From the CI tests, it looks like subprocess.run can sometimes throw a FileNotFoundError that should be caught (are there any other error types that can be thrown?) if the docker command isn't installed on a system.
nightlark
reviewed
Jun 18, 2024
Co-authored-by: Ryan Mast <[email protected]>
nightlark
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If merged this pull request will add support for running Docker Scout on Docker .tar and .tar.gz files