Add get data dir function to ConfigManager

[nightlark]

Cherry-picked adding get_data_dir function to the ConfigManager from PR #267.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

surfactant/configmanager.py:145

• The new function get_data_dir_path introduces new behavior that should be covered by tests. Please add tests to ensure this function works correctly on different platforms.

def get_data_dir_path(self) -> Path:

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (2)

tests/config/test_configmanager.py:81

• The environment variable used here should be 'LOCALAPPDATA' to match the implementation in 'get_data_dir_path'.

expected_data_dir = Path(os.getenv("APPDATA", str(Path("~\AppData\Local").expanduser())))

surfactant/configmanager.py:152

• The environment variable LOCALAPPDATA is used here, but the test uses APPDATA. This inconsistency could lead to errors. Use APPDATA in both the code and the test.

data_dir = Path(os.getenv("LOCALAPPDATA", os.path.expanduser("~\AppData\Local")))

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 suggestion.

Comments skipped due to low confidence (3)

tests/config/test_configmanager.py:82

• The test should assert that the data_dir path ends with the app_name to ensure the path is correctly formed.

assert expected_data_dir in data_dir.parents

tests/config/test_configmanager.py:92

• The test should assert that the data_dir path ends with the app_name to ensure the path is correctly formed.

assert expected_data_dir in data_dir.parents

surfactant/configmanager.py:152

• Inconsistent method usage for expanding user directory. Use Path().expanduser() for consistency.

data_dir = Path(os.getenv("LOCALAPPDATA", os.path.expanduser("~\AppData\Local")))

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.