Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename section to match new ramble interface #345

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

becker33
Copy link
Collaborator

Ramble interface changed spack to software in one spot

Question: do we update our internals to match, or only update our outputs.

This PR only does the outputs, but we could update the internals as well

@pearce8
Copy link
Collaborator

pearce8 commented Aug 23, 2024

Re: do we update our internals to match. We will need to be able to use pip for some of the packages (incomplete example: #283). Will that force us to update our internals? @becker33

@pearce8 pearce8 merged commit 5901815 into develop Aug 23, 2024
6 checks passed
@pearce8 pearce8 deleted the bugfix/spack-vs-software branch August 23, 2024 00:29
@becker33
Copy link
Collaborator Author

No -- currently we have a method called compute_spack_section, and what it computes is put into a section named software. We can rename the method to compute_software_section but I just don't like the new ramble name, so I didn't immediately jump on doing that.

@pearce8
Copy link
Collaborator

pearce8 commented Aug 23, 2024

I am fine with leaving it as compute_spack_section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants