Adding gpu aware mpi to osu-micro-benchmarks w/ rocm variant #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing old experiment location
added 8 commits
December 20, 2024 14:23
github-actions
bot
added
experiment
august-knox
changed the title
added 3 commits
January 28, 2025 10:22
rfhaque
reviewed
Jan 29, 2025
repo/osu-micro-benchmarks/package.py
Outdated
| env.prepend_path("PATH", join_path(mpidir, "one-sided")) | ||
| env.prepend_path("PATH", join_path(mpidir, "collective")) | ||
| if self.spec.satisfies("+rocm"): | ||
| env.prepend_path("LOCAL_RANK", "$MV2_COMM_WORLD_LOCAL_RANK") |
There was a problem hiding this comment.
@august-knox Is this variable system/mpi specific or application-specific?
There was a problem hiding this comment.
@rfhaque It's an application-specific variable used to identify the process rank on a node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding compatibility with gpu-aware mpi on rocm for osu-micro-benchmarks.
Tested with the following system description:
benchpark system init --dest=tioga-gtl llnl-elcapitan cluster=tioga +gtlAdding/modifying a benchmark (docs: Adding a Benchmark)
repo/benchmark_name/package.pyrepo/benchmark_name/application.pyapplication.pyor inrepo/benchmark_name/application.pywill appear in the docs catalogueexperiments/benchmark_name/experiment.pyto define a single node and multi-node experiments.github/workflows/run.yml