-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add modifier for affinity package #584
base: develop
Are you sure you want to change the base?
Conversation
@dyokelson We want to use this modifier to record the affinity. Please let Riyaz know how the data should be output (json format - any more details?) and where the file should be written so that we can inject it into the .cali file. |
depends_on("mpi", when="+mpi") | ||
depends_on("hip", when="+rocm") | ||
depends_on("mpi", when="+mpi") | ||
depends_on("mpi", when="+cuda") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 25 should be:
depends_on("cuda", when="+cuda")
@dyokelson The modifier can now generate the JSON output. Usage:
The JSON file will be available at @nhanford @pearce8 I have only tested this on lassen(cuda) and tioga(rocm). We need to test if the modes are output correctly, in particular there seems to be no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dyokelson please take a look, does this work for injecting into Caliper attributes?
Description
[WIP] Adding a modifier that prints thread/core/gpu affinity for an experiment.
Adding/modifying a system (docs: Adding a System)
systems/system_name/system.py
filesystem_name
in.github/workflows/run.yml
systems/all_hardware_descriptions/hardware_name/hardware_description.yaml
which will appear in the docs catalogueAdding/modifying a benchmark (docs: Adding a Benchmark)
repo/benchmark_name/package.py
repo/benchmark_name/application.py
application.py
or inrepo/benchmark_name/application.py
will appear in the docs catalogueexperiments/benchmark_name/experiment.py
to define a single node and multi-node experiments.github/workflows/run.yml
Adding/modifying core functionality, CI, or documentation:
.github/workflows
and.gitlab/ci
unit tests (if needed)