Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Kripke comm dynamic #591

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

Conversation

gracenansamba
Copy link
Collaborator

Added "https://github.com/gracenansamba/Kripke.git" path to /repo/kripke/package.py and adjusted other changes comparing to my old branch kripke_comm_cali

The current error is kripke@develop required in spack concretization.

May need to make a variant but was not successful.

added these lines for the new caliper metrics.
https://github.com/LLNL/benchpark/blob/Kripke_Comm_dynamic/modifiers/caliper/modifier.py#L45C9-L45C10:
https://github.com/LLNL/benchpark/blob/Kripke_Comm_dynamic/modifiers/caliper-mpi/modifier.py#L27

@github-actions github-actions bot added experiment New or modified experiment application labels Feb 5, 2025
@dyokelson dyokelson marked this pull request as draft February 5, 2025 22:39
@dyokelson
Copy link
Collaborator

dyokelson commented Feb 5, 2025

@gracenansamba ok so in the experiment.py for kripke there is the variant code I show below, this is setting you to the develop version when you run experiment init, so you need to pass in version=comm_cali during the experiment init command to grab that version in from the package.py.

    variant(
        "version",
        default="develop",
        description="app version",
    )

You should be able to do this as is, or you can update this code to look like Caliper's where you can list explicit values (you would just add comm_cali as a value):

    variant(
        "caliper",
        default="none",
        values=(
            "none",
            "time",
            "mpi",
            "cuda",
            "topdown-counters-all",
            "topdown-counters-toplevel",
            "topdown-all",
            "topdown-toplevel",
        ),
        multi=True,
        description="caliper mode",
    )

@pearce8 pearce8 changed the title Kripke comm dynamic [WIP] Kripke comm dynamic Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application experiment New or modified experiment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants