-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json output for thermal data. #434
Conversation
b2ea0b3
to
cb11675
Compare
Hi @kfan326 : please add the documentation for this API and its structure.
I'll review and test on various platforms once we have the docs in the PR as well. |
@kfan326 Is this PR ready for review or do you have more changes to make? The title indicates WIP, but there is also a ready-for-review label. Happy to review once you have resolved the PR. |
@slabasan Yes the PR is ready for review. the Nest power/domain json api PR is ready for review as well. The frequency JSON still needs some cleaning up and should be ready soon. |
5bded48
to
1392dfd
Compare
1392dfd
to
e3fcb8f
Compare
… are accessed by socket, core, thread combo as key)
5c7a736
to
20f05ca
Compare
Closed by #461 |
Description
Added json output for thermal data: Currently implemented for Intel Skylake through Kabylake. AMD Epyc, IBM Power9, AMD GPUs, nVidia GPUs.
Docs: https://variorum.readthedocs.io/en/pr-from-fork-434/
Commit Message:
Fixes #438
Open issues for:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please provide hardware architecture specs and
instructions so we can reproduce.
Checklist:
./scripts/check-code-format.sh
and confirm my code code follows the style guidelines of variorum-DENABLE_WARNINGS=ON
)