Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json output for thermal data. #434

Closed
wants to merge 57 commits into from
Closed

Conversation

kfan326
Copy link
Collaborator

@kfan326 kfan326 commented Jun 28, 2023

Description

Added json output for thermal data: Currently implemented for Intel Skylake through Kabylake. AMD Epyc, IBM Power9, AMD GPUs, nVidia GPUs.

Docs: https://variorum.readthedocs.io/en/pr-from-fork-434/

Commit Message:

json output for thermal data

-add docs
-supports AMD GPUs, nVidia GPUs, Intel CPUs, IBM Power9 CPUs

Fixes #438

Open issues for:

  • ARM CPUs (Can test on Juno)
  • AMD CPUs (Need additional testing in AMD ESMI)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/architecture support (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Build/CI update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please provide hardware architecture specs and
instructions so we can reproduce.

  • Tioga
  • Lassen
{
    "lassen2": {
        "timestamp": 1699313086924113,
        "socket_0": {
            "CPU": {
                "Core": {
                    "temp_celsius_core_0": 24,
                    "temp_celsius_core_1": 23,
                    "temp_celsius_core_2": 23,
                    "temp_celsius_core_3": 23,
                    "temp_celsius_core_4": 24,
                    "temp_celsius_core_5": 24,
                    "temp_celsius_core_6": 24,
                    "temp_celsius_core_7": 24,
                    "temp_celsius_core_8": 24,
                    "temp_celsius_core_9": 24,
                    "temp_celsius_core_10": 0,
                    "temp_celsius_core_11": 0,
                    "temp_celsius_core_12": 24,
                    "temp_celsius_core_13": 24,
                    "temp_celsius_core_14": 24,
                    "temp_celsius_core_15": 24,
                    "temp_celsius_core_16": 24,
                    "temp_celsius_core_17": 24,
                    "temp_celsius_core_18": 24,
                    "temp_celsius_core_19": 24,
                    "temp_celsius_core_20": 24,
                    "temp_celsius_core_21": 24,
                    "temp_celsius_core_22": 24,
                    "temp_celsius_core_23": 24
                },
                "Mem": {
                    "temp_celsius_dimm_0": 0,
                    "temp_celsius_dimm_1": 0,
                    "temp_celsius_dimm_2": 31,
                    "temp_celsius_dimm_3": 32,
                    "temp_celsius_dimm_4": 32,
                    "temp_celsius_dimm_5": 31,
                    "temp_celsius_dimm_6": 0,
                    "temp_celsius_dimm_7": 0,
                    "temp_celsius_dimm_8": 0,
                    "temp_celsius_dimm_9": 0,
                    "temp_celsius_dimm_10": 32,
                    "temp_celsius_dimm_11": 31,
                    "temp_celsius_dimm_12": 31,
                    "temp_celsius_dimm_13": 31,
                    "temp_celsius_dimm_14": 0,
                    "temp_celsius_dimm_15": 0
                }
            },
            "GPU": {
                "temp_celsius_gpu_0": 25,
                "temp_celsius_gpu_1": 25
            }
        }
    }
}
  • Octomore

Checklist:

  • I have run ./scripts/check-code-format.sh and confirm my code code follows the style guidelines of variorum
  • I have added comments in my code
  • My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
  • New and existing unit tests pass with my changes

@tpatki tpatki changed the title json output for thermal data. WIP: json output for thermal data. Jul 6, 2023
@tpatki tpatki added this to the Production: v0.8.0 Release milestone Jul 6, 2023
@tpatki tpatki added status-work-in-progress In progress, not ready to merge. area-feature-support labels Jul 6, 2023
@kfan326 kfan326 marked this pull request as ready for review July 7, 2023 15:45
@kfan326 kfan326 force-pushed the get_thermals_json branch from b2ea0b3 to cb11675 Compare July 10, 2023 21:09
@kfan326 kfan326 marked this pull request as draft July 20, 2023 22:16
@kfan326 kfan326 marked this pull request as ready for review July 20, 2023 22:16
@slabasan slabasan requested a review from tpatki July 20, 2023 22:18
@tpatki tpatki added status-ready-for-review Formatted, and tested on multiple systems. and removed status-work-in-progress In progress, not ready to merge. labels Jul 20, 2023
@tpatki
Copy link
Member

tpatki commented Jul 21, 2023

Hi @kfan326 : please add the documentation for this API and its structure.

I'll review and test on various platforms once we have the docs in the PR as well.

@slabasan
Copy link
Collaborator

slabasan commented Aug 2, 2023

@kfan326 Is this PR ready for review or do you have more changes to make? The title indicates WIP, but there is also a ready-for-review label. Happy to review once you have resolved the PR.

@kfan326
Copy link
Collaborator Author

kfan326 commented Aug 2, 2023

@slabasan Yes the PR is ready for review. the Nest power/domain json api PR is ready for review as well. The frequency JSON still needs some cleaning up and should be ready soon.

@slabasan slabasan changed the title WIP: json output for thermal data. json output for thermal data. Aug 2, 2023
@slabasan slabasan mentioned this pull request Aug 2, 2023
@slabasan slabasan added type-feature status-approved No more revisions are required on this PR and it is ready for merge and removed status-ready-for-review Formatted, and tested on multiple systems. labels Nov 8, 2023
@slabasan slabasan added status-revisions-needed and removed status-approved No more revisions are required on this PR and it is ready for merge labels Nov 14, 2023
@slabasan slabasan self-requested a review November 14, 2023 23:43
@slabasan
Copy link
Collaborator

slabasan commented Dec 1, 2023

Closed by #461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JSON thermal API
3 participants