Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed: Make LmcRbac a dependency for LmcRbacMvc #49

Closed
1 task
visto9259 opened this issue May 24, 2024 · 2 comments
Closed
1 task

Proposed: Make LmcRbac a dependency for LmcRbacMvc #49

visto9259 opened this issue May 24, 2024 · 2 comments
Assignees
@visto9259
Labels
enhancement New feature or request v2 To be implemented in version 2
Milestone
2.0.0

Comments

@visto9259
Copy link
Member

visto9259 commented May 24, 2024 •
edited
Loading

LmcRbac and LmcRbacMvc share a lot of code.
It would be make to have LmcRbacMvc depend on LmcRbac to resuse its codes

For this to work:

  • Remove 'final' from classes that can be extended by LmcRbacMvc
@visto9259 visto9259 added enhancement New feature or request v2 To be implemented in version 2 labels May 24, 2024
@visto9259 visto9259 moved this from 🆕 New to 🏗 In progress in LmcRbac Development May 24, 2024
visto9259 added a commit to visto9259/LmcRbac that referenced this issue May 24, 2024
@visto9259
Fixed issue LM-Commons#49. Replaced Container by Factory
19312fd
@visto9259 visto9259 added this to the 2.0.0 milestone Jul 5, 2024
@visto9259 visto9259 mentioned this issue Jul 5, 2024
Open
7 tasks
@visto9259 visto9259 self-assigned this Jul 5, 2024
@visto9259
Copy link
Member Author

LmcRbac v1 is not widely used (~7k installs). On the other hand, LmcRbacMvc is significantly more used (>200K installs).
The classes that were present in both LmcRbac and LmcRbacMvc are similar but also have significant differences such that a port 1 to 1 is not possible.
When there are significant differences, the LmcRbacMvc version will be prefered give that LmcRbacMvc is more widely used and its classes and methods are similar to other packages that provide RBAC functionality.

@visto9259
Copy link
Member Author

visto9259 commented Jul 8, 2024 •
edited
Loading

The other significant difference is the AssertionInterface.
LmcRbac version is more versatile than LmcRbacMvc and will be preferred.
Use LmcRbacMvc's AssertionPluginManager to replace LmcRbac's AssertionContainer
Deprecate AssertionContainer and related interface

visto9259 added a commit to visto9259/LmcRbac that referenced this issue Jul 8, 2024
@visto9259
Deprecating AssertionContainer (LM-Commons#49)
89f1c68 
Signed-off-by: Eric Richer [email protected] <[email protected]>
visto9259 added a commit to visto9259/LmcRbac that referenced this issue Jul 8, 2024
@visto9259
Adding Identity providers services (LM-Commons#49)
60b8ca7 
Signed-off-by: Eric Richer [email protected] <[email protected]>
visto9259 added a commit to visto9259/LmcRbac that referenced this issue Jul 8, 2024
@visto9259
Adding Identity providers services (LM-Commons#49)
7f4d103 
Signed-off-by: Eric Richer [email protected] <[email protected]>
visto9259 added a commit to visto9259/LmcRbac that referenced this issue Jul 8, 2024
@visto9259
Updated services for remaining items in LM-Commons#49
f743db4 
Signed-off-by: Eric Richer [email protected] <[email protected]>
@visto9259 visto9259 mentioned this issue Jul 10, 2024
Merged
@visto9259 visto9259 mentioned this issue Aug 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in LmcRbac Development Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@visto9259 visto9259

Labels
enhancement New feature or request v2 To be implemented in version 2
Projects
LmcRbac Development
Status: ✅ Done
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@visto9259