Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making "Stop" button actually stop ALL sounds #1535

Closed
unfa opened this issue Dec 30, 2014 · 10 comments
Closed

Making "Stop" button actually stop ALL sounds #1535

unfa opened this issue Dec 30, 2014 · 10 comments
Milestone

Comments

@unfa
Copy link
Contributor

unfa commented Dec 30, 2014

EDIT: The previous title of this issue was "Panic button", but we already have one - the stop button. It only needs improvement.

panic button 01

I sometimes find myself in need to silence all sounds - sticky notes, delay/reverb tails etc.

Do you think it'd be good to have such a tool? It might be helpful in emergency situations of some really bad (and loud) breakage.

@tresf
Copy link
Member

tresf commented Dec 31, 2014

In my opinion, no, stop should do that.

@musikBear
Copy link

stop should do that. 👍

The issue has bearings to failing VSTs -they do not go silent, and hence have own 'stop' buttons

@tresf
Copy link
Member

tresf commented Dec 31, 2014

The issue has bearings to failing VSTs -they do not go silent, and hence have own 'stop' buttons

Or any failing instrument for that matter... Zyn does this to me more than anything else, but if we code a button that can kill all sounds in the GUI, why wouldn't we just make "stop" do that? I fail to see the attraction to a new big panic button. Just fix the one we have. 😄

@Spekular
Copy link
Member

So should this be renamed/edited to be about improving the stop button or closed?

@tresf
Copy link
Member

tresf commented Dec 31, 2014

So should this be renamed/edited to be about improving the stop button or closed?

I don't know. In some ways I feel we need to close the flood gates on these enhancement requests, but they are getting created by some of our communities most active users.... 😕

For this particular bug, I would recommend we identify a specific reproducible runaway sound/plugin and file a bug specific to that, or else this will never get worked on and this will never get closed, making the bug report useless.

It is for that reason I refuse to file this against any version or categorize as bug or enhancement...

@badosu
Copy link
Contributor

badosu commented Jan 1, 2015

I guess we could make it so that every time that we discover a case where the stop button does not cess all sounds is a bug, we schedule priorities as needed.

@Sti2nd
Copy link
Contributor

Sti2nd commented Jan 1, 2015

stop should do that.

Huh. Mixed feelings here. I think it is cool that you can hear the reverb when you stop the song at any time, very useful, but if pause did that and it already does, I don't really have anything against your suggestion Tres.

@tresf
Copy link
Member

tresf commented Jan 1, 2015

I think it is cool that you can hear the reverb when you stop the song

Then perhaps a double-stop implementation?

@unfa unfa changed the title Panic button Making "Stop" button actually stop ALL sounds Jan 1, 2015
@unfa
Copy link
Contributor Author

unfa commented Jan 1, 2015

I've changed the issues' title.

Double stop would be intuitive for me. Actually I tried it but it never worked this way for me, and I always feel the urge to press it again when those delays don't shut up as I'd like.

There could be a hint displayed above the stop button saying:

"Press once to stop transport. Press twice to quiet all sounds (same as a panic button)"

@tresf tresf added this to the 1.3.0 milestone Jan 9, 2015
@Umcaruje Umcaruje added the ux label Jul 4, 2015
@zonkmachine zonkmachine self-assigned this Jan 27, 2018
@zonkmachine zonkmachine removed their assignment Sep 2, 2018
@tresf
Copy link
Member

tresf commented Oct 4, 2018

Consolidated into #3740.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants