Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better transport/playback/playhead behavior #3740

Closed
3 of 11 tasks
musikBear opened this issue Jul 31, 2017 · 14 comments
Closed
3 of 11 tasks

Better transport/playback/playhead behavior #3740

musikBear opened this issue Jul 31, 2017 · 14 comments

Comments

@musikBear
Copy link

musikBear commented Jul 31, 2017

Edited by @tresf

See also:


Original bug report, modified by @tresf for readiblity

LMMS has 3 play-head behaviours |<< , << , and >>. Currently |<< is selected as default butI think it will be best if it is >> that is default.

Really often i start playing a track, then i hear a [part that needs correction] and hit [space]. I should have [clicked pause] but that's a mouse-event, and intuitively space is pressed. [Unfortunately] the play-head jumps to [the beginning of the track]. If >> was default the play-head would [behave like pause by default]. [The Home key can still be used to quickly jump to the beginning of the track.]

This is why i believe that >> is the best option for default behaviour, it is simply inducing fewer arghh situations :)

@tresf
Copy link
Member

tresf commented Jul 31, 2017

I too find this default behavior intolerable when editing a track.

@Spekular
Copy link
Member

Spekular commented Jul 31, 2017 via email

@zonkmachine
Copy link
Member

Isn't the real solution here to add a keyboard shortcut for pause?

Yes. There was a PR/patch submitted for this some six months ago. I'll do some digging.

@zonkmachine
Copy link
Member

I remembered it wrong. It was this one teknopaul@1f9a610
No pause key in there but some improvements nonetheless.

@Umcaruje
Copy link
Member

I also don't like the default behaviour But I use << when working. I think LMMS should just preserve this setting across sessions and tracks, that way everyone can set it however suits them the most.

@husamalhomsi
Copy link
Member

Related: #3288.

I agree with Spekular and Umcaruje.

I was going to suggest that we use "Alt + Space" in Windows and "Command + Space" in macOS because these keys are very close to each other and they're name descriptive because we are altering what a normal "Space" would do, which is stoping, but "Alt + Space" in Windows is used for pop up window menu, unfortunately.
I suggest we either use Ctrl + Space or Shift + Space. These shortcuts are not used by the system in the major operating systems. I prefer Ctrl + Space because they are on the same row and closer to each other than Shift + Space.
Or we can use "P" like Audacity, but that's a bad idea, and Audacity's playback system is different from LMMS's.

I think LMMS should just preserve this setting across sessions and tracks

There are a lot of settings that are also not preserved but should be, like the timeline position.
This deserves another issue.

@tresf tresf changed the title Suggest changing default playhead-behaviour Better playback/playhead behavior Sep 29, 2018
@tresf tresf added this to the 1.3.0 milestone Sep 29, 2018
@tresf tresf added the meta label Oct 4, 2018
@tresf tresf changed the title Better playback/playhead behavior Better transport/playback/playhead behavior Oct 4, 2018
@tresf
Copy link
Member

tresf commented Mar 11, 2019

As part of a pruning effort, this enhancement (and all of the bugs that it consolidates) are archived into a dedicated "Better Workflow" checklist here #4877.

@tresf tresf closed this as completed Mar 11, 2019
@musikBear
Copy link
Author

@Sawuare wrote

Or we can use "P" like Audacity, but that's a bad idea

How about
static Qt.Key | Key_Pause
The key top, outmost right on qwerty kb?
If that is acceptable(?), i will ask for assignment to implement that key for pause

@zonkmachine
Copy link
Member

If that is acceptable(?), i will ask for assignment to implement that key for pause

I believe there is an assignment for this in one of the duplicates for play/pause behavior. You also have three assignments already and you're kind of new to lmms developing so maybe you should focus on those ones before taking on any new tasks?

@zonkmachine
Copy link
Member

#5301
#5332

@musikBear
Copy link
Author

@zonkmachine wrote

maybe you should focus on those ones before taking on any new tasks?

I have made them

image
Done

  • Humanize note-pos and humanize velocity
  • new default envelope for general instrument-class
    Also done
    (needs a new default template that uses a new 3oc, but that is very simple

So 'slate empty' thats why i asked.

@zonkmachine
Copy link
Member

Done

Done where? That's a screenshot. Of what? We need to see the actual code. If it's not merged it's actually not done. Here, no code here: https://github.com/LMMS/lmms/pulls/musikBear

Just push your branches to your github lmms fork and then via the github web interface you open a pull request.

@musikBear
Copy link
Author

You are correct i have not made any PR. I thought it was to little for a PR, and asked on 'Discord, when it was common to make PR, answer was no rules, make one when you like.
I will make one then.

@tresf
Copy link
Member

tresf commented Jun 1, 2020

I thought it was to little for a PR

That's in regards to PR vs. committing directly. If you commit directly, you can still link the commit here! Note, only admins and developers have the ability to commit directly, so a PR is the ONLY way to do it if you're not in those two groups. If it's a small commit and slated against another PR, reference it here. We should always be able to attribute the bug to a code change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants