Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stretch/Shrink/Shorten Patterns via SongEditor #1658

Closed
tresf opened this issue Jan 19, 2015 · 12 comments
Closed

Stretch/Shrink/Shorten Patterns via SongEditor #1658

tresf opened this issue Jan 19, 2015 · 12 comments

Comments

@tresf
Copy link
Member

tresf commented Jan 19, 2015

For some time we've had the ability to stretch a piano roll pattern in the piano roll editor via Select All and the Shift modifier key when dragging a note.

image

Possible functionality:

  1. Open Song Editor
  2. Create a new Piano Roll pattern
  3. Draw some notes
  4. Go back to Song Editor
  5. Hold shift and resize Piano Roll pattern
  6. Piano roll pattern shrinks in size and notes shrink to scale with pattern.

Similar to this current functionality: (animation courtesy of Uros).
0.4.15

This is an enhancement request to add the same functionality to the Song Editor window, including shortening capabilities. :)

@tresf tresf added this to the 1.3.0 milestone Jan 19, 2015
@badosu
Copy link
Contributor

badosu commented Jan 30, 2015

@tresf Could you develop this feature request a little more?

How should this functionality behave/be like?

@tresf
Copy link
Member Author

tresf commented Jan 30, 2015

I'll quote @Sti2nd here as this was extracted from another closed bug report:

You could potentially extend the stretch/shrink functionality from Piano Roll so that resizing a pattern in Song Editor will make use of the Shift shortcut and also stretch the notes.

-Tres

@tresf
Copy link
Member Author

tresf commented Jan 30, 2015

In terms of functionality, I don't know exactly (haven't thought of it much to be honest) but I would assume it would have the same exact effect as doing this in the Piano Roll and it would probably only work for piano roll patterns out of the gate.

Possible functionality:

  1. Open Song Editor
  2. Create a new Piano Roll pattern
  3. Draw some notes
  4. Go back to Song Editor
  5. Hold shift and resize Piano Roll pattern
  6. Piano roll pattern shrinks in size and notes shrink to scale with pattern.

image

@badosu
Copy link
Contributor

badosu commented Jan 30, 2015

@tresf @Sti2nd I just want to really understand if this is something that's really useful and missed, because it's feasible.

@Sti2nd
Copy link
Contributor

Sti2nd commented Jan 30, 2015

Hold shift and resize Piano Roll pattern

Or without Shift. Can someone think of another feature which could make use of resizing a instrument pattern? I think I remember diizy perhaps having a plan, maybe I should tag him and ask?

really useful and missed

Not sure :p If more simple note editing like this feature could be done from the Song Editor I guess it could be really useful and time saving.

@tresf
Copy link
Member Author

tresf commented Jan 30, 2015

Or without Shift. Can someone think of another feature which could make use of resizing a instrument pattern? I think I remember diizy perhaps having a plan, maybe I should tag him and ask?

I suppose "without shift" depends on how intuitive stretching our patterns is.

For example... in an automation pattern and BBEditor pattern, you can make them bigger, but they certainly don't stretch. Why would we allow the same shortcut to have a completely different behavior? Shift seems to be consistent with the Piano Roll and also prevents the confusions that a non-shift shortcut could potentially create.

-Tres

@tresf
Copy link
Member Author

tresf commented Jan 30, 2015

I just want to really understand if this is something that's really useful and missed, because it's feasible.

I think it can be somewhat valuable as melodies/drums patterns can slow down and speed up in an arrangement. This could be a very quick shortcut for doubling or halfing the note frequency of an arrangement.

I can't say I've ever thought of this prior to the OP's suggestion in 1648 though. 😄

@Sti2nd
Copy link
Contributor

Sti2nd commented Jan 30, 2015

You are right, Tres, and simply dragging in and out an instrument pattern should add and remove space normally just as the others. I didn't think that would be useful, but it is.

@unfa
Copy link
Contributor

unfa commented Feb 4, 2015

If this piano roll trick is what I think it is, it works correctly only for
note streaks where every note has the same length. It doesn't work by
multiplying note values by a given fraction (scaling them proportionally),
but by adding a given length to each note and shifting the notes so they
don't overlap. Also the mouse position change is interpreted as a length
increment/decrement for every note, not as the new position of the right
wall of a bounding box containing all selected notes. Is this correct?
31 sty 2015 00:59 "Stian Jørgensrud" [email protected] napisał(a):

You are right, Tres, and simply dragging in and out an instrument pattern
should add and remove space normally just as the others. I didn't think
that would be useful, but it is.


Reply to this email directly or view it on GitHub
#1658 (comment).

@badosu
Copy link
Contributor

badosu commented Feb 4, 2015

@unfa This gif that is referenced by @tresf is not really related to this issue.

In fact the functionality denoted there already exists: select notes on Piano Roll and use <Shift+Drag> on the resize handle.

The functionality that is wanted in this issue actually is about stretching/shrinking patterns on the Song Editor instead of the Piano Roll. The only similarity with the gif denoted here is that it should make notes faster/slower like it is being shown.

@unfa
Copy link
Contributor

unfa commented Feb 5, 2015

Oh, I've gone offtopic again - sorry!
4 lut 2015 22:30 "Amadeus Folego" [email protected] napisał(a):

@unfa https://github.com/unfa This gif that is referenced by @tresf
https://github.com/tresf is not really related to this issue.

In fact the functionality denoted there already exists: select notes on
Piano Roll and use <Shift+Drag> on the resize handle.

The functionality that is wanted in this issue actually is about
stretching/shrinking patterns on the Song Editor instead of the Piano Roll.
The only similarity with the gif denoted here is that it should make notes
faster/slower like it is being shown.


Reply to this email directly or view it on GitHub
#1658 (comment).

@Umcaruje Umcaruje added the gui label Jul 4, 2015
@tresf tresf changed the title Stretch/Shrink Patterns via SongEditor Stretch/Shrink/Shorten Patterns via SongEditor Sep 29, 2018
@tresf
Copy link
Member Author

tresf commented Mar 11, 2019

As part of a pruning effort, this enhancement request is archived into a dedicated "Better Workflow" checklist here #4877.

@tresf tresf closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants