-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/UX inconsistency: Beat and bassline pattern shown in instrument track #3060
Comments
This is not actually a bug, all empty patterns are BB patterns. |
When you zoom close enough, all instrument patterns have steps, by design. This is not a bug, it's always been like this. |
:o So that's what's causing it. Would it be OK to get rid of this and just show the rectangular color for all the zoom levels? |
Actually, thanks to this feature you can create a beat right on the song editor. This is perfect when you don't need to repeat the same thing all bars. |
So you use this to put some patterns with a single note down in the Song Editor? Does that mean you don't use the Beat and Bassline editor? |
Why should they be mutually exclusive? |
It IS a bug, at least from a UI/UX perspective. (Or more accurately an enhancement). If we honor this we should do it in a non-Easter-Egg fashion. |
I still think we have no reason to edit this feature. @simonvanderveldt actually you can use both. Like in this project: https://lmms.io/lsp/?action=show&file=9379 of course I could use some long BBtracks, but that would take more tracks on SE, and you'd have to take note of their names and where to put them. Instead, this way you can edit the beats locally on every sample pattern with 800% zoom, and them give them a name and copy them on other places with 400% or less zoom. Might not be a usual way to compose on most EDM tracks, but for some genres it can be useful. |
@tresf -True, i thought it would be as simple as changing '1600%' to 'B&B-Look', but already at 800% the B&BLook will be shown. |
This isn't about the piano roll.
Just because it's useful doesn't mean it's intuitive. No one is arguing the usefulness of this. When a pattern has zero length notes in the Song Editor, they should probably be displayed as a Piano Roll segment. The "variation patterns" can already be handled by the piano roll and they render correct when zoomed out. That said, I would still advocate for #454 as a more intuitive means for variant patterns. Static BB patterns are certainly difficult to work with for the reasons mentioned. |
Yea I think #454 would be a much better solution. Also, should we discuss retro compatibility? Or is the feature so unused that we can leave it like that? About using piano-roll vs using BB-like blocks, with the latter you can have a overview of the drum section, while if you use pianoroll you'd have to rembember what the kick is doing while editing the snare, and so on. But I understand this is not the point of the issue. |
@DeRobyJ Thanks for the clarification and the example project. that helps a lot with trying to understand how others use this feature. If I understand the concept correctly you use:
What you gain is not having to copy the repeating pattern in the Beat & Bassline editor.
And what if you put everything in a BB track? Then this wouldn't be the case, right? Because they are all next to each other?
This is the issue/use case as described in #454, right?
I ran into another issue with this, namely that ctrl+drag to make a copy of an existing part in the Song Editor doesn't work for these patterns
If it helps you it's obviously useful :) The reason I created this issue is that it caught me by surprise (i.e. it clashed with the principe of least astonishment).
This is pretty much how all the other DAWs I've used work as well. I believe even FL Studio doesn't do composing in the arrangement view (Playlist). (this is not meant as a suggestion not that what others do is the correct thing to do, but as a reference about why I found it surprising that it's different in LMMS) Not sure if this it the right place, but I ran into workflow issues with the BB editor straight away (both the lack of creating variations and composing them within a single track, no way to do slides and no way to control the instruments in it with a MIDI controller) so I switched to single instruments (for now samplers or Synths with banks, haven't found a way to combine the two) that can just be composed using the Piano roll. |
Yea I think we both understood pretty everything. About copying, in 800% it gets a little tricky, you'll have to Ctrl+drag the upper line of the bbpattern, the same place you'd double-click on BBEditor to transform the pattern in a pianoroll. |
In piano-roll? No, not in current Master /PR -You can hold sh and just drag along the bar-indicator, that will mark all notes under that line. Unfortunately a second selection is not possible, so unless all notes you like to 'handle' are displayed at 25% magnification, the job need to be repeated for the rest of the notes, but it is a wonderful option. (search, but could not find the ref) |
@simonvanderveldt It seems like the title of this issue should be updated. |
As part of a pruning effort, this |
Currently, a small BB editor is drawn inside the Song Editor at high zoom levels. As discussed in #3060 this is unintuitive and appears broken (I've seen several other reports of this as a bug). This PR removes this behavior. A quick Discord poll implies that 4 other developers agree with this change, but I'll leave this open a bit in case anyone wants to oppose.
* Don't draw BB editor inside Song Editor Currently, a small BB editor is drawn inside the Song Editor at high zoom levels. As discussed in #3060 this is unintuitive and appears broken (I've seen several other reports of this as a bug). This PR removes this behavior. * Make removal optional
* Don't draw BB editor inside Song Editor Currently, a small BB editor is drawn inside the Song Editor at high zoom levels. As discussed in LMMS#3060 this is unintuitive and appears broken (I've seen several other reports of this as a bug). This PR removes this behavior. * Make removal optional
For an unknown reason (can't reproduce) I managed to get the Song Editor in a state where every click on a normal instrument track would show the Beat and Bassline pattern in the respective bar I clicked on. This didn't happen for a Sample Track.
Double clicking would still bring up the Piano Roll so this seems to be only a visual bug.
[edit] Actually, it's even possible to enable steps in the pattern which then actually trigger the instrument :o
![image](https://cloud.githubusercontent.com/assets/204286/19021393/99c72232-88c0-11e6-98ca-3f07c678920a.png)
The text was updated successfully, but these errors were encountered: