Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piano Roll plays previous paused pattern instead of current pattern #4410

Closed
EtornaZ opened this issue Jun 8, 2018 · 16 comments · Fixed by #6590
Closed

Piano Roll plays previous paused pattern instead of current pattern #4410

EtornaZ opened this issue Jun 8, 2018 · 16 comments · Fixed by #6590
Labels
Milestone

Comments

@EtornaZ
Copy link

EtornaZ commented Jun 8, 2018

I'm on version RC6 of LMMS, with a Windows 10 64Bit computer.

When a box of notes is selected, played and then paused, and a new box of notes is selected and played, the old box of notes plays instead of the new box of notes. If you press the stop button and then press play, the new box of notes will play as intended.

@SecondFlight
Copy link
Member

What do you mean by a selecting "box" of notes and playing it? I wouldn't expect the selection of notes to affect what should be playing, isn't that controlled by the playhead? Could you post a screenshot of some sort? I'm very confused.

@SecondFlight SecondFlight added bug response required A response from OP is required or the issue is closed automatically within 14 days. labels Jun 8, 2018
@0xf0xx0
Copy link
Contributor

0xf0xx0 commented Jun 8, 2018

I think he means chord groups @SecondFlight
play part of a chord, pause, skip ahead to second chord, error happens? @EtornaZ

@EtornaZ
Copy link
Author

EtornaZ commented Jun 8, 2018

I'm sorry, I wasn't very clear at all. Here are some screenshots to hopefully clear the confusion up.
image
I have a selection of notes in the Piano Roll above. I play them, and then pause the notes.
image
I now have a new set of notes selected above, but when I press play, the old selection of notes plays instead of the new selection. If I press stop and then replay, the new notes will play just fine.

@no-response no-response bot removed the response required A response from OP is required or the issue is closed automatically within 14 days. label Jun 8, 2018
@0xf0xx0
Copy link
Contributor

0xf0xx0 commented Jun 8, 2018

sneak peek at new track? lol
Aight, that helps!

@SecondFlight
Copy link
Member

Thanks for the screenshots! So just to confirm, when you say "note selection" you're talking about patterns?

@EtornaZ
Copy link
Author

EtornaZ commented Jun 8, 2018

Yes. I didn't know the correct name for them until now, heh heh.

@SecondFlight
Copy link
Member

I'm using the FL term for them, I think it fits :)

@0xf0xx0
Copy link
Contributor

0xf0xx0 commented Jun 8, 2018

Yeah, that fits lol

@0xf0xx0
Copy link
Contributor

0xf0xx0 commented Jun 8, 2018

isnt there a debugging thing @SecondFlight? maybe u could use that @EtornaZ

@SecondFlight
Copy link
Member

I don't know @gingkathfox, I haven't been active here for very long. If it's reproducible then that wouldn't be needed. I haven't had time to attempt to reproduce yet, but if I remember I'll do that this evening.

@0xf0xx0
Copy link
Contributor

0xf0xx0 commented Jun 9, 2018

ok!

@musikBear
Copy link

Nahh Firstly, nothing is selected. Neither in piano-roll, nor in song-editor.
The lightend TCO shows that it is the one currently opend in piano-roll!
Even if you close piano-roll, it is still focused, and is still the one that are ready to play.
The (faint.. alas) outline, are there to help you find the block, you just had opened in piano-roll. It is not selected.
So if i understand you @EtornaZ -You say that you then open a new song-editor block in piano-roll, and it will show and play the previous opened block?
Is that correctly understood?

@EtornaZ
Copy link
Author

EtornaZ commented Jun 9, 2018

No. I'm saying that when I have a pattern (also knows as a song-editor block) in the Song-Editor, play it in the Piano-Roll, pause it, select a new pattern/song editor block, and play that newly selected pattern/song-editor block in the Piano-Roll, the old pattern/song-editor block plays instead. To fix this, you can press the stop button in the Piano-Roll and then press the play button, and then the correct notes will play.

@husamalhomsi husamalhomsi changed the title Piano Roll plays previous notes in new note box Piano Roll plays previous paused pattern instead of current pattern Jun 9, 2018
@musikBear
Copy link

@EtornaZ :) Its was one word that explain it:
pause
That is the reason.
If you does exactly the same, but stop play, you will not hear the previous pattern.
So it is a difference between pausing play, and stopping play, that causing this to happen.
I have tossed this pause-behaviour around a bit, but i cant find an usecase where it is beneficial.
Guess it could be solved with having song-editor-block-opening, cancel anything that is paused, by setting it to stopped

@EtornaZ
Copy link
Author

EtornaZ commented Jun 10, 2018

Yes, that could be the way, but I figured that if someone pressed pause on a song-editor block and then moved to a new one, they would want their current song-editor box to play instead of the old one without having to press stop. That is how I feel, which is the reason why I reported this as an issue, so a developer could fix it. :)

@madisonsilver
Copy link
Contributor

Here's a video reproduction of the bug: https://www.youtube.com/watch?v=WKMDk8yf5aQ

@PhysSong PhysSong added this to the 1.3 milestone Dec 14, 2022
@PhysSong PhysSong linked a pull request Feb 19, 2023 that will close this issue
PhysSong added a commit that referenced this issue Feb 19, 2023
Fixes #6383 and fixes #4410.

Co-authored-by: Hyunjin Song <[email protected]>
sakertooth pushed a commit to sakertooth/lmms that referenced this issue May 30, 2023
sakertooth pushed a commit to sakertooth/lmms that referenced this issue May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants