Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated sidebar items' font size behaves incorrectly #5714

Closed
Spekular opened this issue Oct 16, 2020 · 2 comments
Closed

Truncated sidebar items' font size behaves incorrectly #5714

Spekular opened this issue Oct 16, 2020 · 2 comments
Milestone

Comments

@Spekular
Copy link
Member

Tested:

  • Windows, master: Truncated items display as bigger(!) than non-truncated ones.
  • Windows, 1.2.2: Truncated items display at a smaller size, but the truncation is still calculated for the normal size. This leaves unused space.
  • Ubuntu 20, master: Font size is the same for truncated/non-truncated items
    On master + windows, when a sidebar item's full name can't be displayed, its font size increases. In 1.2.2, the font size is reduced instead, and on a master build + linux the size is unchanged.

Screenshot of Windows master behavior:
image

Screenshot of Windows 1.2.2 behavior:
image

I propose this be fixed by drawing all items at the same font size, regardless of truncation. If we want to keep the changing font size, I think the behavior should be as on windows + 1.2.2 but with truncation based on the actual font size.

@Spekular Spekular added the bug label Oct 16, 2020
@Spekular Spekular added this to the 1.3 milestone Oct 16, 2020
@Spekular
Copy link
Member Author

Spekular commented Oct 16, 2020

Tentatively milestoning for 1.3 because this should be a simple fix (removing logic rather than adding it). I haven't investigated yet though, so if this turns out to be a Qt bug at work or something else tricky the milestone can be dropped.

@PhysSong PhysSong added the gui label Oct 31, 2020
DigArtRoks added a commit to DigArtRoks/lmms that referenced this issue Nov 8, 2020
For windows platforms, retrieve the system font and set it for the FileBrowserTreeWidget. This makes sure that truncated items will use the font as non-truncated items.
Spekular pushed a commit that referenced this issue Nov 14, 2020
* Fix for the font of truncated sidebar items (#5714).

For windows platforms, retrieve the system font and set it for the FileBrowserTreeWidget. This makes sure that truncated items will use the font as non-truncated items.

* Add TODO to remove the fix when all builds use a recent enough version of qt.

* Add check on QT version and conditionally include the fix.
@Spekular
Copy link
Member Author

Fixed by #5777, thanks @DigArtRoks :)

IanCaio pushed a commit to IanCaio/lmms that referenced this issue Mar 28, 2021
* Fix for the font of truncated sidebar items (LMMS#5714).

For windows platforms, retrieve the system font and set it for the FileBrowserTreeWidget. This makes sure that truncated items will use the font as non-truncated items.

* Add TODO to remove the fix when all builds use a recent enough version of qt.

* Add check on QT version and conditionally include the fix.
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
* Fix for the font of truncated sidebar items (LMMS#5714).

For windows platforms, retrieve the system font and set it for the FileBrowserTreeWidget. This makes sure that truncated items will use the font as non-truncated items.

* Add TODO to remove the fix when all builds use a recent enough version of qt.

* Add check on QT version and conditionally include the fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants