-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase size of the settings menu font #6185
Comments
Here's a quick comparison of a few setup dialogues, in context. (LMMS Scaled, LMMS, Ableton, FL)
Ableton's text is IMO much more legible than ours despite having the same exact size and a lower contrast. FL studio gets away with even lower contrast at just 1px higher base to mean height, so I doubt light on dark text is the issue. I think our drop shadow is reducing text sharpness, because it has a value in-between that of the text and the background. Removing it might fix the issue without adjusting size. If size is to be adjusted, note the config window on the far left. By scaling the sub-section content to fill the window, the settings text size becomes roughly equivalent to the current heading size, and comparable to other text inside LMMS. |
We can definitely shorten a lot of these setting descriptions by removing the unnecessary "enable" text and other changes (mostly to verb use).
|
Is there a way to enlarge all UI fonts altogether or scale the whole UI? IMO it's all pretty small |
I was also suffered but found that a CSS file in the theme directory matters. You can edit them directly, but I recommend you to copy the theme directory somewhere under your HOME then modify, and update the theme path in LMMS. |
I believe @michaelgregorius is working on this. |
Hi @atvrider, the settings dialog has been reworked with pull request #6779. It now uses layouts and the default font size of the application/system. @zonkmachine has posted a very nice side-by-side comparison in this comment. Can you please check with a recent build if your issue has been resolved? |
Closing this issue due to the changes made in pull request #6779. Please reopen it if there is something missing. |
Why is it so hard to add font settings? |
@deadhitter1, there are currently two types of GUI elements used in LMMS:
The latter will scale with the global scaling factor that's configured for the desktop environment. Implementing these in a scalable way is a rather large undertaking because for each element it must be checked where it is used in the GUI and the corresponding layouts must be switched to a flexible layout or at least adjusted to accommodate for the additional space that is needed. Enabling the setting of an application font size in the setup dialog would likely also mean that the style sheets must be adjusted, i.e. many explicit font sizes would have to be removed. As you can hopefully see there are several reasons why it's hard to add font settings. |
My apologies, I had too many tabs open and I intended to post this on a different github issue. multitasking late at night |
Just make the font size bigger this is terrible, where's the consciousness of the team? |
@patrickReiis, the problem is that LMMS uses hard-coded font sizes and layouts in many places and that these are not easily adjusted. You can find more information in this comment: #6185 (comment) Simple exampleHere's a simple example that might let some people understand better why adjusting the font sizes is not an easy task. LMMS' own combo box implementation is used in several places and is one of the elements that sets its font size to a hard coded value. It's size is set in pixels here: lmms/src/gui/widgets/ComboBox.cpp Line 56 in d703f39
So let's look what it would look like if we wanted to increase the font size to 24 by just changing the 10 to 24. Here's the result: Ooops, that just increased the font size and nothing else because the widget does not take the current font size into account when it paints all its other elements. One line above the setting of the font size the (fixed) height of the combo box is set: lmms/src/gui/widgets/ComboBox.cpp Line 54 in d703f39
So let's look what happens if we increase this to 50 to make the height somewhat match the font size again (ratios are: 10/22, 24/50). The result now looks as follows: This shows that the painting code more or less expects the height to be 22 because the pixmap does not scale accordingly. The changes also break the layouts of the GUI elements where the combo box is used. There are many more home-brewn widgets like the combo box (just search for Cause of the problemsOne of the problems is that these widgets should not have been implemented from scratch with insufficient scalability but rather should have inherited from existing Qt widgets, e.g. The code should also have used more Qt layouts instead of hard coding the positions of things. This would somewhat prevent the breakage of layouts when the sizes of individual elements change. Help appreciated@patrickReiis, if you are a developer your help will be greatly appreciated. If you are not a developer please stop telling developers what's easy and what's not ("Just make the font size bigger [...]"). |
I understand that it's not an easy task because the code started wrong, and if something starts wrong it's logically impossible to finish right. What I'm trying to say is the following: So, what is the point of having a gigantic planet made entirely of gold if you can't interact with it? This is the problem with LMMS, the software is gold, but I can't see it. So, what I ask is that the CEO or the manager or whoever has control over this, to stop building features, fixing bugs, and put all men power to fix this font issue. I'd like to help, but I don't have the sufficient knowledge (despite being a developer myself). |
There is no CEO or manager in this project. From what I get it's more of a bunch of people who work on different things that interest them. I am not on the Discord server though, so I don't really know if some more coordination is organized there or if some sort of organization can be recognized there. |
Could the default size of the settings menu font be changed to be about twice as large as it currently is? The current size seems unreasonably small, I have pretty average eyesight up close and I have to lean in and focus really hard to be able to see what the text says.
The size of text for the line that says "Graphical user interface (GUI)" should be about the size of text for all of the options in this menu.
The text was updated successfully, but these errors were encountered: