Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better functionality of LFO-ctrl with random spectrum #6354

Closed
musikBear opened this issue Mar 29, 2022 · 4 comments · Fixed by #6850
Closed

Better functionality of LFO-ctrl with random spectrum #6354

musikBear opened this issue Mar 29, 2022 · 4 comments · Fixed by #6850

Comments

@musikBear
Copy link

Enhancement Summary

I suggest that frequency should influence the effect of spectrum-choice random when a LFO-ctrl is controlling a dial (Here PITCH)

Justification

In all other spectrum-choices like sine or triangle, changing FREQ has significant influence

Mockup

No

Explanation

Look at this picture
image
Here the PITCH dial has been connected to the LFO-ctrl, and random-spectrum has been chosen. Turning the FREQ-dial on LFO-ctrl does not influence the output.
I would think the random positions should be kept unchanged controlled by the FREQ dial setting. The span should ideally be between one whole note and 1/192 (-or as it is now).

@allejok96
Copy link
Contributor

This would be awesome! Then you would essentially have a LFO that gave you a new random value ever beat or so. (And setting FREQ to maximum would behave like the current random)

@Spekular
Copy link
Member

I would find this pretty inconsistent as the frequency knob maps to hz for all of the other waveforms. I think it'd make more sense to map it to a lowpass filter when using the noise oscillator, and add the time-stepping as a separate feature for all controllers. After all, a sine-shaped controller with the same stepped updating could also be useful.

@musikBear
Copy link
Author

This would be awesome! Then you would essentially have a LFO that gave you a new random value ever beat or so. (And setting FREQ to maximum would behave like the current random)

That is what i intend, but @specular remarks about inconsistency are absolutely valid. It would be absolutely random so no consistency between plays!

My thoughts were only aimed at having FREQ influencing random-spectrum, since it influence the other shapes.

Combining @allejok96 idea and speculars remark on consistency could be achieved in a different way. Here i mockup a 'random' automation pattern, and bind PITCH to it
image
That 'works' in as mutch as it creates a reproducible output, but it sounds awful!
It is ofcouse not in scale. Pure ear bleeding kakaphony !
In fact, a non kakaphonic reproducible random pattern is better made by muting an instrument and then just record random white keystrokes.
Here we get like
image
The inconvinience here is that humans are bAAAd in making random devellopment, we have a tendency to make 'patterns'
But at least this kakaphony is in scale, so theoretically 'a composition' (ask T. Monk about that ) 😏

@consolegrl
Copy link
Contributor

I have been working on humanizing some drum samples (removing "machine-gunning") from my acoustic drum setups, and this is the feature I've been wanting to implement. In synthesizers it's called sample-and-hold, the fact that the FREQ knob does nothing with the random waveform is inconsistent with the other waveforms. FREQ changes the rate at which the sine/square/saw etc modulate the controller, but it doesn't change the rate at which random values are delivered. Furthermore, to achieve the current functionality of ignoring the FREQ knob, just set the FREQ knob to an arbitrarily low value to effectively turn off the sample-and-hold functionality; this would be a pure addition.

consolegrl added a commit to consolegrl/lmms that referenced this issue Sep 7, 2023
LFO controller's "white noise" wave shape didn't respect the frequency
knob at all, so Sample-and-Hold was added to extend the functionality
of the LFO Controller with this random waveshape.
The original functionallity can still be accessed by setting the
FREQ knob to minimum (0.01)
consolegrl added a commit to consolegrl/lmms that referenced this issue Sep 7, 2023
Added upgrade routine for old projects using the
white noise on LFO controllers
@DomClark DomClark linked a pull request Sep 7, 2023 that will close this issue
zonkmachine pushed a commit that referenced this issue Sep 12, 2023
* fixes #6354: Sample and Hold for LFO Controller

LFO controller's "white noise" wave shape didn't respect the frequency knob at all, so
Sample-and-Hold was added to extend the functionality of the LFO Controller with this
random waveshape. The original functionallity can still be accessed by setting the
FREQ knob to minimum (0.01)

---------

Co-authored-by: Kevin Zander <[email protected]>
Co-authored-by: saker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants