Migrate to new LV2 header paths #6990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakertooth
reviewed
Nov 18, 2023
sakertooth
approved these changes
Nov 18, 2023
messmerd
reviewed
Nov 18, 2023
| @@ -29,7 +29,7 @@ | |||
|
|
|||
| #ifdef LMMS_HAVE_LV2 | |||
|
|
|||
| #include <lv2/lv2plug.in/ns/ext/urid/urid.h> | |||
| #include <lv2/urid/urid.h> | |||
There was a problem hiding this comment.
Looks like our automated Linux builds can't find this. This is probably another reason why our Linux builds need to be upgraded to ubuntu-20.04 or ubuntu-22.04, since I believe we're still using 18.04.
|
@wujekbrezniew Our Linux CI has been upgraded, so if you rebase on the latest master, this PR should build successfully on Linux now. |
Merge changes from base repo
|
Done c: |
DomClark
changed the title
Rossmaxx
pushed a commit
that referenced
this pull request
May 21, 2024
JohannesLorenz
added a commit
to JohannesLorenz/lmms
that referenced
this pull request
Jun 2, 2024
JohannesLorenz
added a commit
to JohannesLorenz/lmms
that referenced
this pull request
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lv2 headers to comply to latest versions of lv2. It was neccesary for me to build LMMS on Ubuntu over KXStudio packages.
lv2-dev will change to 1.18.10 in next stable ubuntu release as launchpad says:
https://packages.ubuntu.com/search?keywords=lv2-dev