Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Linux CI to Ubuntu 20.04 #7015

Merged
merged 18 commits into from
May 8, 2024
Merged

Update Linux CI to Ubuntu 20.04 #7015

merged 18 commits into from
May 8, 2024

Conversation

messmerd
Copy link
Member

@messmerd messmerd commented Dec 6, 2023

This PR updates the Linux CI builds to use Ubuntu 20.04 (focal) instead of Ubuntu 18.04 (bionic).

A few changes were needed for a successful build:

Benefits:

  • Updates GCC from 7.4 to 9.3, which enables support for std::filesystem in all LMMS CI build runners except for MinGW, taking us one step closer to permitting its use in LMMS code. Once MSVC builds fully replace MinGW, or if the MinGW builds are updated to Ubuntu 20.04, std::filesystem will be usable.
  • Updates Qt from 5.9.5 to 5.12.8.
  • Updates SDL from SDL 1.2.15 to SDL 2.0.10.
  • Updates fluidsynth from 1.1.9 to 2.1.1, enabling per-note panning for SF2.
  • Adds Sndio audio and midi interfaces
  • Can now use short-style LV2 header paths in Migrate to new LV2 header paths #6990
  • ...

Closes #6993

@messmerd messmerd marked this pull request as ready for review December 14, 2023 22:36
Copy link
Member

@DomClark DomClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, subject to approval of LMMS/lmms-ci-docker#15.

@messmerd messmerd mentioned this pull request Dec 16, 2023
@kamkamkamkamkamkamkamkam

we should really be using the latest LTS, it would fix some library specific bugs like fluidsynth crashing when loading large soundfonts which was fixed in fluidsynth 2.2.2, we'd be stuck on 2.1.1 in ubuntu 20.04

@PhysSong
Copy link
Member

we should really be using the latest LTS

Unfortunately, that will prevent creating AppImages which works on the oldest supported version of LTS. Running on the oldest supported LTS also ensures that LMMS is not broken on such distribution versions.

it would fix some library specific bugs

Good point. There is a discussion(stale?): #6195

@tresf
Copy link
Member

tresf commented May 8, 2024

Veal submodule was recently update on master; a rebase should remove it from this PR; limit scope.

messmerd and others added 18 commits May 8, 2024 11:35
Try to fix issue with wine

Try again

again

furthermore

moreover

Revert some changes; Fix SDL

test

test - take 2

Try container

Work around old git version in container

Install git

Revert container; Another attempt

Try Ubuntu 22.04

Fix Qt

Try aptitude

Safe resolver

debug info

Back to Ubuntu 20.04

Print more info

Remove an option

Print deb file checksums

Use diff

Print more info
@tresf
Copy link
Member

tresf commented May 8, 2024

LGTM, subject to approval of LMMS/lmms-ci-docker#15.

Agreed. Despite the huge number of commits, this is a very simple PR. Merging.

@tresf tresf merged commit d71116b into LMMS:master May 8, 2024
9 checks passed
@messmerd messmerd deleted the ci-update branch May 8, 2024 18:33
@messmerd messmerd added linux CI Issues/pull requests regarding continuous integration(CI) system labels Nov 20, 2024
@tresf tresf mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issues/pull requests regarding continuous integration(CI) system linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Linux CI to support Ubuntu 20.04
5 participants