-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Linux CI to Ubuntu 20.04 #7015
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, subject to approval of LMMS/lmms-ci-docker#15.
we should really be using the latest LTS, it would fix some library specific bugs like fluidsynth crashing when loading large soundfonts which was fixed in fluidsynth 2.2.2, we'd be stuck on 2.1.1 in ubuntu 20.04 |
Unfortunately, that will prevent creating AppImages which works on the oldest supported version of LTS. Running on the oldest supported LTS also ensures that LMMS is not broken on such distribution versions.
Good point. There is a discussion(stale?): #6195 |
Veal submodule was recently update on master; a rebase should remove it from this PR; limit scope. |
Try to fix issue with wine Try again again furthermore moreover Revert some changes; Fix SDL test test - take 2 Try container Work around old git version in container Install git Revert container; Another attempt Try Ubuntu 22.04 Fix Qt Try aptitude Safe resolver debug info Back to Ubuntu 20.04 Print more info Remove an option Print deb file checksums Use diff Print more info
Agreed. Despite the huge number of commits, this is a very simple PR. Merging. |
This PR updates the Linux CI builds to use Ubuntu 20.04 (focal) instead of Ubuntu 18.04 (bionic).
A few changes were needed for a successful build:
ghcr.io/lmms/linux.gcc:20.04
veal
submodule to the latest commit on the defaultladspa
branch-Wno-format-truncation
for ZynAddSubFx build.-Wno-format-overflow
for calf/veal build.Benefits:
std::filesystem
in all LMMS CI build runners except for MinGW, taking us one step closer to permitting its use in LMMS code. Once MSVC builds fully replace MinGW, or if the MinGW builds are updated to Ubuntu 20.04,std::filesystem
will be usable.Closes #6993