Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's becoming increasingly frustrating to zoom in and out #7117

Closed
SalutanisOrkonus opened this issue Feb 19, 2024 · 5 comments · Fixed by #7118
Closed

It's becoming increasingly frustrating to zoom in and out #7117

SalutanisOrkonus opened this issue Feb 19, 2024 · 5 comments · Fixed by #7118

Comments

@SalutanisOrkonus
Copy link

Enhancement Summary

Recent push makes it so you can't hover over most of the song editor to zoom (ctrl+scrollwheel), hovering over a track at all resizes it instead. Maybe track resizing should only happen when hovering over the track button itself?
(also this is more of a bug but when zooming, zooming out works fine but it feels like zooming in goes wherever it feels)

Justification

Makes zooming in and out with ctrl+scrollwheel bearable again

@enp2s0
Copy link
Contributor

enp2s0 commented Feb 19, 2024

Fully agree. Ctrl-scroll is my main way of interacting with the song editor zoom ever since the 100%-200%-400% combobox was replaced with the slider. losing that means the only way to reliably zoom it is to drag the slider with the mouse which is very cumbersome.

Since my workflow is nearly completely midi-based I don't think I've ever used the vertical resize feature of the tracks, but horizontal zoom is absolutely critical. It's something I interact with several times per minute while editing a song.

@qnebra
Copy link

qnebra commented Feb 20, 2024

I think it could be fixed by adding additional modifier key to resize track. Something like:

Ctrl + Mousewheel = Zoom
Ctrl + Alt + Mousewheel = Track resize

@Spekular
Copy link
Member

I would say #3763 is relevant here as well. If zoom + modifier is going to be used for a vertical zoom, I'd expect it to apply to all tracks rather than just one.

@SalutanisOrkonus
Copy link
Author

in addition because I just noticed: You can now only scroll the song editor (when there's enough tracks for that to start being an option) if your mouse is directly on the scroll bar on the side, very annoying, please fix.

@michaelgregorius
Copy link
Contributor

Sorry, I wasn't aware that the handling of the wheel events in the TrackView would mask so many other handlers. I also accidentally accepted every event in the wheelEvent method and not only the ones that are actually handled.

Pull request #7118 fixes this. It implements the proposal made here in that the alt key has to be pressed for the track to resize:

  • Alt + Control: Resize track height by one pixel.
  • Alt + Shift: Resize track height by five pixels.

All other events bubble up, i.e. zooming and scrolling via control and alt now works again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants