Don't play anything when no sample is loaded (AFP) #7266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonkmachine
approved these changes
May 18, 2024
sakertooth
approved these changes
May 18, 2024
There was a problem hiding this comment.
We might want to switch to using nullptr to represent having no buffer, but callers would have to handle that case properly and not just use the nullptr buffer like it was a normal one, which was why I went with just having empty buffers. I might still consider switching to check against nullptr in the future if it makes more sense though.
| @@ -170,6 +170,8 @@ void Sample::setAllPointFrames(int startFrame, int endFrame, int loopStartFrame, | |||
|
|
|||
| void Sample::playRaw(sampleFrame* dst, size_t numFrames, const PlaybackState* state, Loop loopMode) const | |||
| { | |||
| if (m_buffer->size() < 1) { return; } | |||
There was a problem hiding this comment.
I think this expresses the intent more clearly, but it's not that much of a big deal.
Suggested change
| if (m_buffer->size() < 1) { return; } | |
| if (m_buffer->empty()) { return; } |
messmerd
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I realized the PR tittle should've been the commit message and the other way around)
Fixes #7265