Check for valid pattern when focussing out pianoroll #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents a segmentation fault when closing an empty piano roll, fixing issue LMMS#2050.
|
Looks good. Thanks @ThomasJClark, and @midi-pascal for testing (#2050 (comment)). For the future, our style guidelines suggest that curly-braces should always be on their own line, but that's pretty minor so I'll take care of that bit for you after merging. |
Wallacoloo
added a commit
that referenced
this pull request
Jun 20, 2015
Check for valid pattern when focussing out pianoroll
|
@Wallacoloo I noticed the curly brace on the same line too but did not want to be too picky because this PR solves a crash :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a segmentation fault when closing an empty piano roll,
fixing issue #2050.