Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quantize button to Piano Roll (WIP) #2483

Merged
merged 3 commits into from
May 5, 2016
Merged

Add Quantize button to Piano Roll (WIP) #2483

merged 3 commits into from
May 5, 2016

Conversation

grejppi
Copy link
Contributor

@grejppi grejppi commented Dec 12, 2015

WORK IN PROGRESS

Inspired by a conversation on #lmms:

14:03 < klopsi-u3> is there a way to force an already recorded track to a lower 
                   quantisation?
...
14:42 < grejppi> klopsi-u3: none in the interface
14:42 < grejppi> that would be a useful feature though
14:44 < klopsi-u3> ok
14:45  * grejppi might hack that in
14:45 < klopsi-u3> :)
14:45 < grejppi> or at least try
14:46 < grejppi> I've already been sidetracked by so many things today c:
14:50 < klopsi-u3> i think there should be a seperate button for 'quantise 
                   piano roll'
14:50 < klopsi-u3> iow, not automatically shift quantisation if the 
                   quantisation dropdown is changed
14:51 < grejppi> yeah
14:51 < klopsi-u3> maybe even only quantise selected notes

There is now a new button in the Piano Roll editor toolbar:

toolbr

If there is a selection, it will quantize the selected area to the current quantization level (1/4 in these screenshots for clarity):

quantize_sel

Without a selection the entire pattern is quantized.

quantizeproper

Known issues:

  • As you can see from the last screenshot, there are still cases where some notes are left as-is. I will investigate this.
  • This has absolutely not been tested yet. At least it builds for now.

@BaraMGB
Copy link
Contributor

BaraMGB commented Dec 13, 2015

There should be a difference between length and position quantization.

@grejppi
Copy link
Contributor Author

grejppi commented Dec 13, 2015

@BaraMGB that would be a matter of changing the behaviour of Note::quantizeLength().

@zonkmachine
Copy link
Member

Cool! Tested it and it seem to work just fine.

@zonkmachine
Copy link
Member

Swing?

swing

@grejppi
Copy link
Contributor Author

grejppi commented Apr 25, 2016

@zonkmachine what happens in that screenshot?

@zonkmachine
Copy link
Member

Yes, that wasn't all too clear.
I'm trying to show that from implementing quantisation to adding swing/groove shouldn't be that much work. I haven't dug any deeper into the various versions of swing but an Issue for it with links to articles is here -> #1091

@grejppi
Copy link
Contributor Author

grejppi commented May 4, 2016

@LMMS/developers I don't generally like merging my own pull requests, but unless there are any objections I will do that in 24 hours. This does not seem to break existing functionality 👍

@tresf
Copy link
Member

tresf commented May 5, 2016

👍

@grejppi grejppi merged commit c94d6e8 into LMMS:master May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants