Resize Gear Icon #4255
Resize Gear Icon #4255
Conversation
|
Nice! #4217 is a lengthy discussion - I'll let someone else who was involved in it chime in verifying that this is a change people want. But before this gets merged, remove that extra 1 MB text file named |
|
I like this conceptually, but it seems like a decision that @RebeccaDeField and @Umcaruje made with decent reasoning. Anyhow, the old one is less pixelated/blurry so that will probably be @Umcaruje's first complaint when he gets to reviewing this. |
👍 |
Great attention to detail, thanks. The consensus there seems to be to move away from the gear entirely, which would free even more space. |
|
In #2563, the discussion led to the solution to the space problem of aligning the LEDs vertically: |
|
@Mark-Agent003 yes, that can still happen I feel, but I think the horizontal space being the "driver for change" is a bit over-valued. Condensing components and adding functionality should be cognizant of each-other, but not strictly tied. The right-click context menu is more holistically paired with our entire UI and @JohannesLorenz was correct about that so that should be implemented regardless. I've had some opinions about Mute and Solo myself (I think they should be |
Agreed. There isn't any immediate work currently being made on #2563 , so until then, there isn't a need for condensation. |
|
@Mark-Agent003 Github is showing that you made all the .png's in this PR executable. I'm guessing this is Windows-related, but if you know how to change the permissions back to read/write like they were before, that would be a good thing.
@Umcaruje Care to weigh in on this PR? This has been open for > 2 months, so I'd like to resolve it. If nobody else weighs in, I'll merge it in a few days - I'm of the opinion that the current gear size does look a bit jarring and that making it smaller is a small change which benefits the look as it is now, without getting in the way of future UI overhauls. |
|
I agree that the gear icon looks a bit too big currently, but this change adds padding around the icon which makes the matter worse in my honest opinion. In #4217 it was decided that this button should be removed and replaced with a RMB context menu, so this does not matter that much, but I would find the current look more balanced than the new icon. Maybe the OP wants to create an icon that's in between the sizes offered to be the best of the both worlds. Sorry for my late responses lately, life's been crazy busy. |
|
@Wallacoloo Thanks for noticing the permission change. I also changed two other images in the theme folder from one of my PRs that also had their permissions changed. @Umcaruje I increased the size, here's a snippet: |
|
@Umcaruje Waiting for you to weigh in on the last change, since you were the one who recommended it in the first place. I know you've been busy with things, but I have to balance that with getting decisions made in a timely manner. A huge turn-off for any developer is to submit a patch just for it to be ignored for months on end. Anyway, I don't mean to sound antagonistic or anything. I'll give it two days, and after that I'll assume the latest change is what you had in mind & merge it. |
|
Sorry, I have a bad habit of resolving stuff directly with people without
keeping the tracker in the loop. I talked to the OP on discord and asked to
see the project file and it doesn’t seem to me the icon is as pixel perfect
as it could be. So we’re working on that. I do approve of the size of the
icon now, think it’s perfect.
|
|
Can the current gear icon be replaced with a thin spanner icon? |
@Mark-Agent003 Did you do any progress on the 'pixel perfect' issue? The new cogwheel looks good. |
|
As this is not a bug fix, I'll change the PR base from stable-1.2 to master in 7 days. |
|
Base has been changed. |
|
This change has been completed and merged here #4255 |
This will simply resize the gear icon to be smaller to fit the modern theme and to match the single-window concept better. Comparison:
(Before: Bottom, After: Top)
(Updated)
Related: #4217