-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automation Editor point fine tuning with double click #5292
Conversation
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS
🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://5093-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.569-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5093?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://5092-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.569-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5092?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://5090-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.569-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5090?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/k5m67s4pud0h95eg/artifacts/build/lmms-1.2.1-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/28696442"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/e5en8sjfpe06gjkv/artifacts/build/lmms-1.2.1-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/28696442"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://5094-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.569-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5094?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "cf50b86bd1607b3988899292e62e2effdab4bc41"} |
8c0ed95
to
11872a7
Compare
11872a7
to
cf50b86
Compare
@russiankumar |
@tecknixia
|
I just adapted this PR to have #5712 as a base branch, since it changes quite a lot of the AutomationEditor/AutomationPattern and some tweaking would be necessary to make this PR compatible with it. I kept the original authorship by commiting with IanCaio/lmms@feature/automationProgression...IanCaio:feature/automationProgressionFineTuning |
Co-authored-by: tecknixia <[email protected]>
Closing this as #5923 which rewrote this over the new AutomationPattern framework was already merged. |
…MMS#5923) Co-authored-by: tecknixia <[email protected]>
…MMS#5923) Co-authored-by: tecknixia <[email protected]>
Related to issue #5225 and old PR #5232 (closed)
Allows user to double click an automation point in the Automation Editor, and enter new number to adjust the y level for that point. It also improves mouse cursor interaction with the point, and shows the point's Y level when mouse cursor is over a point.
This PR involves the creation of
doubleClickEvent
, creation of variablem_pointYLevel
, and the use ofmouseMoveEvent
anddrawCross
.m_pointYLevel
is created and used to hold a point's Y level position.m_pointYLevel
is set when the mouse moves over a point.m_pointYLevel
is used when opening an input dialog box, for the current value.m_pointYLevel
returns to0
.m_pointYLevel
is0
, the tool tip indrawCross
displays the Y level position of the mouse.m_pointYLevel
is greater than0
, the tool tip indrawCross
displays the point's Y level position.