-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run dos2unix
#6198
Run dos2unix
#6198
Conversation
This seems like a good opportunity to add CRLF fixing to |
Thank you for the article! |
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Windows
macOSLinux
🤖{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://15128-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.147%2Bgf9dce33d9-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15128?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://15129-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.147%2Bgf9dce33d9-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15129?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/hjqt938u8aot0uwj/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/41184238"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/b30m6fx7f7cwj6hq/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/41184238"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://15126-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.147%2Bgf9dce33d9-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15126?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://15125-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.147%2Bgf9dce33d9-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/15125?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "54cf4dd40b27fc3f0572046b5df92655ce20018e"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
I just got around to testing the modified |
Interfase works well, instrument presets work well, midi import/export as well. Tested on W10. |
@rdrpenguin04 I'll merge this now. Want squash or rebase+ff? |
Probably squash |
Late to this PR, but @TechnoPorg thanks for this insight, it's helped me on another project as well. 👌 |
Every CRLF line ending in the main repo should now be replaced with LF. I tried to only touch text files, but it's possible something slipped through the cracks.
Let me know if you have any questions!