Fix broken data file upgrade #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2022
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Windows
🤖{"platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/pqj97x6x6ma70x9e/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/42214771"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/90dgk91511xokge0/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/42214771"}]}, "commit_sha": "8b2a309148ef714bad2cf62467238577105b2f39"} |
JohannesLorenz
requested changes
Jan 15, 2022
JohannesLorenz
approved these changes
Jan 15, 2022
|
Test review minimum: The following should work with all kinds of clips (Automation Clip, BB Clip, MidiClip (these are the clips with MIDI notes), SampleClip):
|
|
Another problem found: when dragging and dropping a sample track from the Song Editor to the Beat+Bassline Editor, it does not work. Update: Apparently, this happened because I accidentally opened an invalid sample file, which is a bug but out of the scope of this PR (more details: #6283). Other than this, everything seems to work fine in my tests. |
|
Oh, OK. Then I'd say let's merge this? It can't get much worse 🥲 |
|
For me, it is ready to be merged. |
allejok96
pushed a commit
to allejok96/lmms
that referenced
this pull request
Jan 20, 2022
Fixes issues introduced in previous commit (55d361f), which affected loading, saving and drag-dropping of clips.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the data file upgrade breakage introduced in #6226.