Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in Clang build #6893

Merged
merged 12 commits into from
Sep 29, 2023
Merged

Fix warnings in Clang build #6893

merged 12 commits into from
Sep 29, 2023

Conversation

messmerd
Copy link
Member

@messmerd messmerd commented Sep 25, 2023 •
edited
Loading

This PR fixes all the warnings generated by Clang/AppleClang when building the Core and GUI.
For now, I've refrained from fixing any warnings generated from plugins or 3rd party libraries, since that would likely require a lot more work.

Changes include:

  • Fixed unused variable warnings
  • Fixed implicit conversion warnings
  • Fixed unused lambda capture warnings
  • Fixed an operator precedence bug from Classier enums #6760

Veratil
Veratil requested changes Sep 25, 2023
View reviewed changes
src/core/InstrumentFunctions.cpp Outdated Show resolved Hide resolved
src/core/InstrumentFunctions.cpp Outdated Show resolved Hide resolved
src/gui/modals/SetupDialog.cpp Show resolved Hide resolved
sakertooth
sakertooth approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@sakertooth sakertooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@messmerd messmerd merged commit 8fb9c3e into LMMS:master Sep 29, 2023
@messmerd messmerd deleted the fix-clang-warnings branch September 29, 2023 00:23
michaelgregorius added a commit to michaelgregorius/lmms that referenced this pull request Oct 1, 2023
@michaelgregorius
Merge remote-tracking branch 'upstream/master' into 2510-SetupDialogW…
339ee6d 
…ithLayouts-MasterMerge

Merge master to integrate the changes of:
* f102777: Classier enums
* 7aca8ae: SetupDialog: Warn of unusual buffersizes
* 8fb9c3e: Fix warnings in Clang build (LMMS#6893)

Solved conflicts in:
* src/gui/modals/SetupDialog.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veratil Veratil Veratil requested changes

@DomClark DomClark DomClark approved these changes

@sakertooth sakertooth sakertooth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@messmerd @DomClark @Veratil @sakertooth