Adding proportional scrolling #7476
Conversation
|
Just checked it out and it's working great! Thanks. |
|
Alright, I sped up the horizontal scrolling in the Piano Roll and Automation Editor by about 3x, so now the Piano Roll's horizontal scrolling is closer to the speed of the vertical scrolling. I didn't do exactly 3x, since that made it scroll exactly 1 beat, which made the grid pattern line up and look odd like it wasn't scrolling. |
|
It seems good now! |
include/AutomationEditor.h
Outdated
| @@ -241,6 +241,8 @@ protected slots: | |||
| QScrollBar * m_leftRightScroll; | |||
| QScrollBar * m_topBottomScroll; | |||
|
|
|||
| void incrementLeftRightScoll(int value); | |||
There was a problem hiding this comment.
I have just noticed that something like update or adjust would have been better than increment. The reason is that it does not always increment but can also decrement depending on the sign of value.
However, I don't want to be too picky. 😅
Add proportional scrolling to the song editor, piano roll and automation editor. Proportional scrolling means that if for example a certain measure is on the right side of the song editor then it will take a certain number of mouse wheel moves to get it to the left side of the editor. It is the same number of wheel moves regardless of the zoom level.
Fixes #7474 by making the scroll amount change based on the zoom amount.
The implementation is slightly different in the
SongEditorversus thePianoRolland theAutomationEditor, since theSongEditorhas precise zoom control while the others have zoom levels. I opted to usepixelsPerBar()in theSongEditorto calculate the zoom level for simplicity, since the zooming model is in log scale.I actually had this on feature my mind awhile ago when I was implementing continuous autoscrolling, but I decided to leave it to a different pr and forgot about it. Now I've been reminded, so here it is.
Also, please let me know if the scrolling speed is too fast/too slow. Currently the scrolling speed is equal to the old scrolling speed at default zoom.