Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unrestricted splash screen geometry #7588

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Fix unrestricted splash screen geometry #7588

merged 1 commit into from
Nov 20, 2024

Conversation

SpomJ
Copy link
Contributor

@SpomJ SpomJ commented Nov 18, 2024

Fixes #7587.

Copy link
Contributor

@Rossmaxx Rossmaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Copy link
Member

@messmerd messmerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to reproduce the bug on my machine (Linux Mint 22, Cinnamon, X11), but the changes here are simple enough that I'm fine with merging it

@SpomJ
Copy link
Contributor Author

SpomJ commented Nov 20, 2024

It might be a wayland bug, I didn't check it on X11

It most likely is, it's probably a janky implementation on Qt side, but more verbosity never hurts. ...right?

@messmerd messmerd merged commit 7e65a87 into LMMS:master Nov 20, 2024
9 of 11 checks passed
rubiefawn pushed a commit to rubiefawn/lmms that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Startup popup can be resized while it shouldn't be
3 participants