Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add codespell lint job into workflows & fix typos #35

Merged
merged 6 commits into from
Dec 18, 2023
Merged

feat: add codespell lint job into workflows & fix typos #35

merged 6 commits into from
Dec 18, 2023

Conversation

vuittont60
Copy link
Contributor

Closes #34

  1. feat: add codespell lint job into workflows
  2. fix typos caught by lint job.

Please help me to review. Thank you very much.

@vuittont60
Copy link
Contributor Author

hello @dr-orlovsky could you help me to review? Thank you very much.

dr-orlovsky
dr-orlovsky approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow

dr-orlovsky
dr-orlovsky reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I need to compile it locally / fix the compilation bugs to make sure it does not break anything

@dr-orlovsky dr-orlovsky merged commit 8294d57 into LNP-WG:master Dec 18, 2023
15 of 22 checks passed
@vuittont60
Copy link
Contributor Author

@dr-orlovsky thank you.

@dr-orlovsky
Copy link
Contributor

Thank you, I didn't know such thing exists - and it is amazing how many typos were there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-orlovsky dr-orlovsky dr-orlovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add codespell lint job into workflows
2 participants
@vuittont60 @dr-orlovsky