-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chain mismatch for regtest #52
Conversation
I did not tried it with regtest, but used with testnet and signet. Can you give them a try? |
Yes, I tried with signet but received the same error. Steps to reproduce
PS: I used rust_bitcoin project to generate signet master private key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the solutuion!
Once small improvement in code style, since you asked about more idiomatic way. And can you please run rustup update nightly && cargo +nightly fmt
, since here we use latest nighlty formatter and it does the job differenlty than a previous ones (leading to code formatting changes unrelated to this PR).
Also after that please squash everything into a single commit not to affect git blame
status for the parts of code which are unrelated to the PR.
Sorry for a lot of details :(
50b78bb
to
11db1a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 11db1a7
I tried running the project in regtest mode, but the current check does not verify testnets correctly (occurs ChainMismatch).
I am a newbie in rust, but I started learning to contribute to LNPBP projects.
Can you recommend a better "idiomatic" implementation?
Thanks