build using dune #24
Merged
build using dune #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gares
force-pushed
the
dune
branch
2 times, most recently
from
023b7b7 to
ad3ef7a
Compare
gares
force-pushed
the
dune
branch
3 times, most recently
from
c863b91 to
6d27f2b
Compare
rgrinberg
reviewed
Apr 21, 2019
src/dune
Outdated
| (preprocess (per_module | ||
| ((pps ppx_deriving.std trace_ppx --trace_ppx-on) elpi_runtime_trace_on) | ||
| ((pps ppx_deriving.std trace_ppx --trace_ppx-off) elpi_runtime_trace_off) | ||
| ((action (system "camlp5o -I . -I +camlp5 pa_extend.cmo pa_lexer.cmo %{input-file}")) elpi_parser) |
There was a problem hiding this comment.
A bit curious about the necessity of system here. You don't seem to be using shell features.
There was a problem hiding this comment.
I tried with run, but it insists in running camlp5o.opt that is then unable to load the cmos.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to build elpi with dune.
Current annoyances:
Dependency analysis: Unnecessary/undesired compilation unit included in executable ocaml/dune#753 to remove(happens to work after elpi 1.3)elpi_from file name prefixesHackish workaround: