Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change convention of shear to be consistent with SLSim conventions of ellipticity #255

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

sibirrer
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (ff63c4d) to head (8a41495).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #255      +/-   ##
==========================================
- Coverage   97.89%   97.74%   -0.15%     
==========================================
  Files          70       70              
  Lines        4653     4655       +2     
==========================================
- Hits         4555     4550       -5     
- Misses         98      105       +7     
Files with missing lines Coverage Δ
slsim/lens.py 96.62% <100.00%> (-0.36%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@nkhadka21 nkhadka21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sibirrer for fixing this!

@sibirrer sibirrer merged commit 2369db8 into LSST-strong-lensing:main Sep 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants