Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multi-source plane conventions and solver and added EPL velocity dispersions #287

Merged
merged 16 commits into from
Nov 22, 2024

Conversation

sibirrer
Copy link
Contributor

@sibirrer sibirrer commented Nov 22, 2024

Fixed a bug with the multi-source plane analytical lens equation solver, added routines to self-consistently related velocity dispersion and power-law slopes.

Also debugged a recently introduced bug on the line of sight function output interpretation

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.83%. Comparing base (94bf863) to head (9cd36e1).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
slsim/lens.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   97.86%   97.83%   -0.03%     
==========================================
  Files          74       74              
  Lines        4954     4999      +45     
==========================================
+ Hits         4848     4891      +43     
- Misses        106      108       +2     
Files with missing lines Coverage Δ
slsim/Deflectors/DeflectorTypes/epl_sersic.py 100.00% <100.00%> (ø)
slsim/Deflectors/deflector.py 97.67% <100.00%> (ø)
slsim/Deflectors/velocity_dispersion.py 100.00% <100.00%> (ø)
slsim/Sources/source.py 98.58% <100.00%> (ø)
slsim/lens.py 97.15% <94.44%> (-0.50%) ⬇️
---- 🚨 Try these New Features:

Copy link
Collaborator

@nkhadka21 nkhadka21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sibirrer, thank you very much for this PR! It looks good to me.

@nkhadka21 nkhadka21 merged commit 371e064 into LSST-strong-lensing:main Nov 22, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants