mypy and pylint fixes

tests/cli/plot/test_plot_cli.py

@@ -24,8 +24,9 @@ def test_cli_help() -> None:
 
 
 @pytest.mark.skipif(missing_ci_data, reason="NO CI data")
-def test_cli_run(setup_project_area) -> None:
+def test_cli_run(setup_project_area: int) -> None:
 
+    assert setup_project_area == 0
     runner = CliRunner()
 
     result = runner.invoke(
@@ -36,8 +37,9 @@ def test_cli_run(setup_project_area) -> None:
 
 
 @pytest.mark.skipif(missing_ci_data, reason="NO CI data")
-def test_cli_inspect(setup_project_area) -> None:
+def test_cli_inspect(setup_project_area: int) -> None:
 
+    assert setup_project_area == 0
     runner = CliRunner()
 
     result = runner.invoke(
@@ -48,8 +50,9 @@ def test_cli_inspect(setup_project_area) -> None:
 
 
 @pytest.mark.skipif(missing_ci_data, reason="NO CI data")
-def test_cli_extract_datasets(setup_project_area) -> None:
+def test_cli_extract_datasets(setup_project_area: int) -> None:
 
+    assert setup_project_area == 0
     runner = CliRunner()
 
     result = runner.invoke(

tests/conftest.py

@@ -6,8 +6,8 @@
 
 
 @pytest.fixture(name="setup_project_area", scope="session")
-def setup_project_area(request) -> None:
-
+def setup_project_area(request: pytest.FixtureRequest) -> int:
+    
     if not os.path.exists('tests/temp_data/projects/ci_test/data'):
         os.makedirs('tests/temp_data/projects/ci_test/data')
         # FIXME, replace with a curl command
@@ -22,8 +22,9 @@ def setup_project_area(request) -> None:
             'tests/temp_data/data/test/ci_test_blend_baseline_100k.hdf5'
         )
 
-
-    def teardown_project_area():
+    def teardown_project_area() -> None:
         os.system("\\rm -rf tests/temp_data")
 
     request.addfinalizer(teardown_project_area)
+
+    return 0

tests/plotting/test_control.py

@@ -9,8 +9,9 @@
 
 
 @pytest.mark.skipif(missing_ci_data, reason="no ci data")
-def test_load_yaml(setup_project_area) -> None:
+def test_load_yaml(setup_project_area: int) -> None:
 
+    assert setup_project_area == 0
     control.clear()
 
     # Load the testing yaml file
@@ -21,8 +22,9 @@ def test_load_yaml(setup_project_area) -> None:
 
 
 @pytest.mark.skipif(missing_ci_data, reason="no ci data")
-def test_run(setup_project_area) -> None:
+def test_run(setup_project_area: int) -> None:
 
+    assert setup_project_area == 0
     control.clear()
 
     _out_dict = control.run('tests/ci_plot_groups.yaml', outdir='tests/temp_data/plots')

tests/plotting/test_dataset_factory.py

@@ -9,7 +9,9 @@
 
 
 @pytest.mark.skipif(missing_ci_data, reason="no ci data")
-def test_load_yaml(setup_project_area) -> None:
+def test_load_yaml(setup_project_area: int) -> None:
+
+    assert setup_project_area == 0
 
     # Load the testing yaml file
     RailDatasetFactory.clear()