Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the NEWS_PATH environment variable #1513

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

daanboer
Copy link
Contributor

The NEWS_PATH environment variable can be used to point the app to the location of the news.json file, which is used to populate the news component on the homepage. This is particularly useful when deploying using docker containers.

@daanboer daanboer enabled auto-merge (squash) November 19, 2024 18:57
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.61%. Comparing base (0f201c8) to head (8405f5d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
- Coverage   80.68%   80.61%   -0.07%     
==========================================
  Files         222      222              
  Lines        5773     5773              
  Branches     1046     1046              
==========================================
- Hits         4658     4654       -4     
- Misses       1037     1039       +2     
- Partials       78       80       +2     
Flag Coverage Δ
app 57.19% <ø> (-0.45%) ⬇️
converter 65.31% <ø> (ø)
database 83.32% <ø> (ø)
schema 92.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@daanboer daanboer merged commit 100bc49 into main Nov 19, 2024
9 checks passed
@daanboer daanboer deleted the add_news_env_var branch November 19, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant