Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unavailable sets from the selection #1618

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Remove unavailable sets from the selection #1618

merged 1 commit into from
Jan 9, 2025

Conversation

daanboer
Copy link
Contributor

@daanboer daanboer commented Jan 9, 2025

This fixes the client-side exception in the reaction template picker.

Resolves #1405

This fixes the client-side exception in the reaction
template picker.
@daanboer daanboer merged commit a9e4dbb into main Jan 9, 2025
7 checks passed
@daanboer daanboer deleted the issue-1405 branch January 9, 2025 14:36
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.68%. Comparing base (2dfc41c) to head (b940053).
Report is 84 commits behind head on main.

Files with missing lines Patch % Lines
app/src/shared/swr-reaction-picker.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1618      +/-   ##
==========================================
+ Coverage   80.48%   80.68%   +0.19%     
==========================================
  Files         222      221       -1     
  Lines        5776     5762      -14     
  Branches     1046     1032      -14     
==========================================
  Hits         4649     4649              
+ Misses       1051     1035      -16     
- Partials       76       78       +2     
Flag Coverage Δ
app 57.52% <0.00%> (+1.22%) ⬆️
converter 64.66% <ø> (-0.66%) ⬇️
database 83.32% <ø> (ø)
schema 92.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daanboer daanboer added bug Something isn't working application labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client-side exception in reaction template picker
1 participant